From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl
Date: Wed, 27 Apr 2011 16:54:44 +0200 [thread overview]
Message-ID: <m2vcxz922z.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1303873107-14082-1-git-send-email-macpaul@andestech.com> (Macpaul Lin's message of "Wed, 27 Apr 2011 10:58:27 +0800")
Hi Macpaul,
> clean up with 2.6.38 checkpatch.pl
There is indeed only one non-whitespace hunk in there:
@@ -69,8 +69,9 @@ int do_bdinfo ( cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
defined(CONFIG_440SP) || defined(CONFIG_440SPE)
print_str ("procfreq", strmhz(buf, bd->bi_procfreq));
print_str ("plb_busfreq", strmhz(buf, bd->bi_plb_busfreq));
-#if defined(CONFIG_405GP) || defined(CONFIG_405EP) || defined(CONFIG_XILINX_405) || \
- defined(CONFIG_440EP) || defined(CONFIG_440GR) || defined(CONFIG_440SPE) || \
+#if defined(CONFIG_405GP) || defined(CONFIG_405EP) || \
+ defined(CONFIG_XILINX_405) || defined(CONFIG_440EP) || \
+ defined(CONFIG_440GR) || defined(CONFIG_440SPE) || \
defined(CONFIG_440EPX) || defined(CONFIG_440GRX)
print_str ("pci_busfreq", strmhz(buf, bd->bi_pci_busfreq));
#endif
It's ok that you do the line wrapping, but actually with such lists we
require alphabetical sorting of the clauses, so can you please juggle
the list so that the "XILINX_405" gets to the end?
Thanks!
Detlev
--
The continental people think life is a game. The English think
cricket is a game.
-- George Mikes
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-04-27 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 2:52 [U-Boot] [PATCH 1/4] cmd_bdinfo.c: clean up with 2.6.38 checkpatch.pl Macpaul Lin
2011-04-27 2:55 ` Macpaul Lin
2011-04-27 2:58 ` [U-Boot] [PATCH v2] " Macpaul Lin
2011-04-27 14:54 ` Detlev Zundel [this message]
2011-04-28 2:35 ` Macpaul Lin
2011-04-29 8:56 ` Detlev Zundel
2011-04-29 8:59 ` Macpaul Lin
2011-04-29 11:08 ` Detlev Zundel
2011-04-29 10:24 ` Wolfgang Denk
2011-04-29 11:09 ` Detlev Zundel
2011-04-28 2:28 ` [U-Boot] [PATCH v3] cosmetic: cmd_bdinfo.c: clean up by using checkpatch.pl Macpaul Lin
2011-04-29 8:53 ` Detlev Zundel
2011-05-12 21:31 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vcxz922z.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox