[U-Boot] Policy for checkpatch usage?

Detlev Zundel
2011-04-21T15:46:10Z

Hi Eric,

> On Thu, Apr 21, 2011 at 04:29:17PM +0200, Detlev Zundel wrote:
>> What about the problem with checkpatch errors in current code, i.e. the
>> origin of this sentence:
>>
>> Also warnings produced for context lines (i.e. existing code) rather
>> than actual changes can also be ignored.
>
> How about replacing it with this:

Thanks for the input. Current base for discussion:

Checkpatch is a tool that can help you find some style problems, but
is imperfect, and the things it complains about are of varying
importance. So use common sense in interpreting the results.

Warnings that clearly only make sense in the Linux kernel can be
ignored. This includes "Use #include <linux/$file> instead of
<asm/$file>" for example.

If you encounter warnings for existing code, not modified by your
patch, consider submitting a separate, cosmetic-only patch -- clearly
described as such -- that *precedes* your substantive patch.

Anyone unhappy with that? Will this help newcomers?

Happy easter everyone, and remember around easter some people like to
hide eggs, _not_ bugs ;)

Detlev

--
Whenever you find yourself on the side of the majority it is
time to pause and reflect.
-- Mark Twain
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de