public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] TFTP - check for len == 0 before storing
Date: Wed, 20 Apr 2011 15:46:27 +0200	[thread overview]
Message-ID: <m2vcy9f32k.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1QCSeq-0004h5-4Z@wolf.netmodule.com> (David Andrey's message of "Wed, 20 Apr 2011 10:21:01 +0200")

Hi David,

> I had a problem with an old TFTP Server which is sending a second "last"
> data block with "len == 0" at end. It's clearly not RFC conform, but I
> still made a additional check in u-boot/tftp to avoid a wrong "filesize"
> value. This wrong filesize value caused some trouble by NAND operations.

Please look at our patch guidelines[1] on how to submit patches.
Especially a signed-off-by is missing on this patch.

Moreover, please put the explanation into the commit log so that one can
learn the rationale for the change when studying the source with git.

Thanks
  Detlev

[1] http://www.denx.de/wiki/U-Boot/Patches

-- 
LISP has  jokingly been  described as  "the most  intelligent way to  misuse a
computer".  I think that  description a great  compliment because it transmits
the full  flavour of  liberation:  it has assisted a number of our most gifted
fellow humans in thinking previously impossible thoughts. - Edsger W. Dijkstra
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

      reply	other threads:[~2011-04-20 13:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-20  8:21 [U-Boot] TFTP - check for len == 0 before storing David Andrey
2011-04-20 13:46 ` Detlev Zundel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2vcy9f32k.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox