From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Tue, 24 May 2011 15:17:29 +0200 Subject: [U-Boot] [PATCH 2/4] [v2] nand_util: convert nand_write_skip_bad() to flags In-Reply-To: <3ea2081d8694778a35ca03a7940242dae8e88c75.1305823168.git.bengardiner@nanometrics.ca> (Ben Gardiner's message of "Thu, 19 May 2011 12:49:23 -0400") References: <3ea2081d8694778a35ca03a7940242dae8e88c75.1305823168.git.bengardiner@nanometrics.ca> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Ben, > In a future commit the behaviour of nand_write_skip_bad() > will be further extended. > > Convert the only flag currently passed to the nand_write_ > skip_bad() function to a bitfield of only one allocated > member. This should avoid an explosion of int's at the > end of the parameter list or the ambiguous calls like > > nand_write_skip_bad(info, offset, len, buf, 0, 1, 1); > nand_write_skip_bad(info, offset, len, buf, 0, 1, 0); > > Instead there will be: > > nand_write_skip_bad(info, offset, len, buf, WITH_YAFFS_OOB | > WITH_OTHER); > > Signed-off-by: Ben Gardiner > CC: Detlev Zundel > > --- > Changes since v1: > * rebased to HEAD of git://git.denx.de/u-boot-nand-flash.git : ff7b4a0 > ("env_nand: zero-initialize variable nand_erase_options") > * renamed the flag from WITH_OOB to WITH_YAFFS_OOB (Detlev Zundel) > * introduce 'WITH_DEFAULTS' flag defined as 0 so as to convert also > the remaining nand_write_skip_bad() call (Detlev Zundel) I don't remember requesting this change - and rereading my mails I cannot find anything either. Actually I consider this define to be overkill. What I was asking for was to change all occurrences of the function call - a 0 for flags is ok with me. If you remove that again, you can add my Acked-by: Detlev Zundel Cheers Detlev -- I've been examining the existing [linux] kernel configuration system, and I have about concluded that the best favor we could do everybody involved with it is to take it out behind the barn and shoot it through the head. -- Eric S. Raymond on linux-kbuild Mar 2000 -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de