From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Policy for checkpatch usage?
Date: Wed, 20 Apr 2011 15:40:14 +0200 [thread overview]
Message-ID: <m2zknlf3cx.fsf@ohwell.denx.de> (raw)
In-Reply-To: <BANLkTi=VLfeY0P-ksnG_uNgG+T8r6G0wbQ@mail.gmail.com> (Graeme Russ's message of "Wed, 20 Apr 2011 22:43:11 +1000")
Hi Graeme,
> On Wednesday, April 20, 2011, Graeme Russ <graeme.russ@gmail.com> wrote:
>> On Wednesday, April 20, 2011, Detlev Zundel <dzu@denx.de> wrote:
>>> Hi,
>>>
>>
>>>
>>> As a base for discussion, what about this:
>>>
>>> ??Use common sense in interpreting the results of checkpatch. Warnings
>>> ??that clearly only make sense in the Linux kernel can be ignored. ?Also
>>> ??warnings produced for _context lines_ rather than actual changes can
>>> ??also be ignored.
>>
>> One man's common sense is another's idiocy
>>
>> I vote for a zero warnings, zero errors U-Boot specific checkpatch
>>
>
> I also think that all patches should be submitted with a checkpatch
> summary with an explaination for any errors or warnings - this will at
> least save a little effort for the maintainers and reduce the number of
> patches bounced only to have the checkpatch problems argued away
> by the author anyway
When we accept 0 errors and 0 warnings only, then we will always see the
same text :)
As long as we are not there, I do agree but then we should come up with
a recipe on how to automate this. I looked into git format-patch but it
does not seem to have such an option. Does anyone have a clever
one-liner for this?
Cheers
Detlev
--
Math and Alcohol don't mix, so...
PLEASE DON'T DRINK AND DERIVE
[Motto of the society: Mathematicians Against Drunk Deriving]
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2011-04-20 13:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 9:24 [U-Boot] Policy for checkpatch usage? Detlev Zundel
2011-04-20 10:15 ` Graeme Russ
2011-04-20 12:43 ` Graeme Russ
2011-04-20 13:40 ` Detlev Zundel [this message]
2011-04-20 13:38 ` Detlev Zundel
2011-04-20 16:51 ` Scott Wood
2011-04-21 0:09 ` Graeme Russ
2011-04-21 5:18 ` Wolfgang Denk
2011-04-21 14:24 ` Detlev Zundel
2011-04-21 14:29 ` Detlev Zundel
2011-04-21 14:49 ` Eric Cooper
2011-04-21 14:56 ` Fabian Cenedese
2011-04-21 15:04 ` Eric Cooper
2011-04-21 15:37 ` Detlev Zundel
2011-04-21 15:19 ` Detlev Zundel
2011-04-21 15:46 ` Detlev Zundel
2011-04-23 15:29 ` Andreas Pretzsch
2011-04-27 9:07 ` Detlev Zundel
2011-04-21 16:10 ` Scott Wood
2011-04-22 0:43 ` Graeme Russ
2011-04-22 6:18 ` Albert ARIBAUD
2011-04-22 10:56 ` Graeme Russ
2011-04-22 8:54 ` Wolfgang Denk
2011-04-22 10:52 ` Graeme Russ
2011-04-22 12:46 ` Wolfgang Denk
2011-04-25 5:37 ` Graeme Russ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zknlf3cx.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox