From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] mpc5xxx/cpu_init.c: fix warning: unused variable 'cdm'
Date: Wed, 03 Feb 2010 13:53:35 +0100 [thread overview]
Message-ID: <m2zl3q5vlc.fsf@ohwell.denx.de> (raw)
In-Reply-To: <1265018287-22037-2-git-send-email-wd@denx.de> (Wolfgang Denk's message of "Mon, 1 Feb 2010 10:58:07 +0100")
Hi Wolfgang,
> Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Detlev Zundel <dzu@denx.de>
By the way, now that we have a patch touching this stuff on the mailing
list - would anyone object to removing the mgt5100 stuff? If I am not
missing anything, this is not being used anywhere and makes the code
look overly complicated.
Would such a cleanup patch be accepted?
Thanks
Detlev
> ---
> cpu/mpc5xxx/cpu_init.c | 12 +++++++-----
> 1 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/cpu/mpc5xxx/cpu_init.c b/cpu/mpc5xxx/cpu_init.c
> index 2aa6e1c..560c9b3 100644
> --- a/cpu/mpc5xxx/cpu_init.c
> +++ b/cpu/mpc5xxx/cpu_init.c
> @@ -40,12 +40,14 @@ void cpu_init_f (void)
> (struct mpc5xxx_mmap_ctl *) CONFIG_SYS_MBAR;
> volatile struct mpc5xxx_lpb *lpb =
> (struct mpc5xxx_lpb *) MPC5XXX_LPB;
> - volatile struct mpc5xxx_cdm *cdm =
> - (struct mpc5xxx_cdm *) MPC5XXX_CDM;
> volatile struct mpc5xxx_gpio *gpio =
> (struct mpc5xxx_gpio *) MPC5XXX_GPIO;
> volatile struct mpc5xxx_xlb *xlb =
> (struct mpc5xxx_xlb *) MPC5XXX_XLBARB;
> +#if defined(CONFIG_SYS_IPBCLK_EQUALS_XLBCLK)
> + volatile struct mpc5xxx_cdm *cdm =
> + (struct mpc5xxx_cdm *) MPC5XXX_CDM;
> +#endif /* CONFIG_SYS_IPBCLK_EQUALS_XLBCLK */
> #if defined(CONFIG_WATCHDOG)
> volatile struct mpc5xxx_gpt *gpt0 =
> (struct mpc5xxx_gpt *) MPC5XXX_GPT;
> @@ -187,11 +189,11 @@ void cpu_init_f (void)
>
> # if defined(CONFIG_SYS_IPBCLK_EQUALS_XLBCLK)
> /* Motorola reports IPB should better run at 133 MHz. */
> -#if defined(CONFIG_MGT5100)
> +# if defined(CONFIG_MGT5100)
> setbits_be32(&mm->addecr, 1);
> -#elif defined(CONFIG_MPC5200)
> +# elif defined(CONFIG_MPC5200)
> setbits_be32(&mm->ipbi_ws_ctrl, 1);
> -#endif
> +# endif
> /* pci_clk_sel = 0x02, ipb_clk_sel = 0x00; */
> addecr = in_be32(&cdm->cfg);
> addecr &= ~0x103;
--
Question : If you were redesigning UNIX, what would you do differently?
Ken Thompson: I'd spell creat with an e.
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
next prev parent reply other threads:[~2010-02-03 12:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 9:58 [U-Boot] [PATCH 2/3] mpc5xxx/cpu_init.c: fix warning: unused variable 'gpt0' Wolfgang Denk
2010-02-01 9:58 ` [U-Boot] [PATCH 3/3] mpc5xxx/cpu_init.c: fix warning: unused variable 'cdm' Wolfgang Denk
2010-02-03 12:53 ` Detlev Zundel [this message]
2010-02-03 14:10 ` Wolfgang Denk
2010-03-08 12:45 ` [U-Boot] [PATCH] mpc5xxx: Remove all references to MGT5100 Detlev Zundel
2010-03-08 14:05 ` Detlev Zundel
2010-03-12 9:01 ` [U-Boot] [PATCH v2] " Detlev Zundel
2010-03-12 21:29 ` Wolfgang Denk
2010-03-15 16:02 ` Detlev Zundel
2010-03-15 17:04 ` Wolfgang Denk
2010-03-14 0:05 ` Wolfgang Denk
2010-02-03 19:00 ` [U-Boot] [PATCH 3/3] mpc5xxx/cpu_init.c: fix warning: unused variable 'cdm' Wolfgang Denk
2010-02-03 12:52 ` [U-Boot] [PATCH 2/3] mpc5xxx/cpu_init.c: fix warning: unused variable 'gpt0' Detlev Zundel
2010-02-03 19:00 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2zl3q5vlc.fsf@ohwell.denx.de \
--to=dzu@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox