public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Enable port-mapped access to 16550 UART
Date: Mon, 02 Nov 2009 14:46:25 +0100	[thread overview]
Message-ID: <m2zl75yr7y.fsf@ohwell.denx.de> (raw)
In-Reply-To: <d66caabb0910291348n5391d3b8we6cb3fe456639ce2@mail.gmail.com> (Graeme Russ's message of "Fri, 30 Oct 2009 07:48:41 +1100")

Hi Graeme,

>> we at least start using the Linux convention and turn all the register
>> accesses into "serial_{in,out}" and define these for X86 and !X86 like
>> you did.
>>
>> This way should be somewhat clearer than defining a "writeb" not to be a
>> writeb after all, which I find confusing.
>>
>> What do you think?
>>
>
> So essentially go with my patch but rename uart_writeb to serial_out and
> uart_readb to serial_in? If so, I'll re-spin

Yes please.

Thanks
  Detlev

-- 
The fact is, volatile on data structures is a bug. It's a wart in the C 
language. It shouldn't be used.
                                   -- Linus Torvalds 
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

      reply	other threads:[~2009-11-02 13:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-24  1:27 [U-Boot] [PATCH] Enable port-mapped access to 16550 UART Graeme Russ
2009-10-27 21:11 ` [U-Boot] [PING][PATCH] " Graeme Russ
2009-10-28 16:13 ` [U-Boot] [PATCH] " Detlev Zundel
2009-10-28 21:18   ` Graeme Russ
2009-10-29 15:42     ` Detlev Zundel
2009-10-29 20:48       ` Graeme Russ
2009-11-02 13:46         ` Detlev Zundel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2zl75yr7y.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox