public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Detlev Zundel <dzu@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] include/ns16550.h: Unify structure declaration for	registers
Date: Mon, 27 Apr 2009 18:09:42 +0200	[thread overview]
Message-ID: <m2zle2oz7d.fsf@ohwell.denx.de> (raw)
In-Reply-To: <m2ljpmqfb2.fsf@ohwell.denx.de> (Detlev Zundel's message of "Mon,  27 Apr 2009 17:36:33 +0200")

Hello Shinya,

>> If there's no good alternatives, I think reverting is a good idea
>> because there must be other platforms affected by this change.

I just checked again - the "problematic" cases can only be REG_SIZE 2
and 4:

[dzu at pollux u-boot-testing (master)]$ grep CONFIG_SYS_NS16550_REG_SIZE include/configs/* | grep -v 'REG_SIZE.*\(1\|(-4)\|-4\|-8\)'
include/configs/AP1000.h:#define CONFIG_SYS_NS16550_REG_SIZE    4
include/configs/CU824.h:#define CONFIG_SYS_NS16550_REG_SIZE     4
include/configs/mcc200.h:#define CONFIG_SYS_NS16550_REG_SIZE    4
include/configs/ppmc7xx.h: * CONFIG_SYS_NS16550_REG_SIZE - 64-bit accesses to 8-bit port
include/configs/xilinx-ppc.h:#define CONFIG_SYS_NS16550_REG_SIZE 4

CU824 incidentally is the platform that I tested the patch on (PowerPC),
ppmc7xx is a false positive, so only three platforms remain.  I'm almost
100% sure that mcc200 also works, as it is also a PowerPC platform
comparable to CU824. Is AP1000 your platform?

We should really work to get these platforms in order, the fallout is
not as big as may have been expected...

Cheers
  Detlev

-- 
Summary [of object-oriented programming in Perl 5]
That's all about there is to it. Now you just need to go off and buy a
book about object-oriented design methodology, and bang  your forehead
with it for the next six months or so.    Larry Wall [Creator of Perl]
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de

  reply	other threads:[~2009-04-27 16:09 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03 14:45 [U-Boot] [PATCH] include/ns16550.h: Unify structure declaration for registers Detlev Zundel
2009-04-03 14:55 ` Detlev Zundel
2009-04-03 23:24 ` Wolfgang Denk
2009-04-25  1:21 ` Shinya Kuribayashi
2009-04-27 13:41   ` Detlev Zundel
2009-04-27 14:26     ` Shinya Kuribayashi
2009-04-27 15:36       ` Detlev Zundel
2009-04-27 16:09         ` Detlev Zundel [this message]
2009-04-29 18:51         ` Shinya Kuribayashi
2009-04-29 19:12           ` Shinya Kuribayashi
2009-04-30 13:30             ` Detlev Zundel
2009-04-30 14:10               ` Detlev Zundel
2009-05-01  0:56               ` Shinya Kuribayashi
2009-05-01  5:29                 ` Shinya Kuribayashi
2009-04-30 12:26           ` Detlev Zundel
2009-04-30 12:52             ` Jerry Van Baren
2009-04-30 14:08               ` Detlev Zundel
2009-04-30 14:38                 ` Detlev Zundel
2009-04-30 17:06                 ` Jerry Van Baren
2009-05-01  2:21               ` Shinya Kuribayashi
2009-05-01  1:59             ` Shinya Kuribayashi
2009-05-04 15:40               ` Detlev Zundel
2009-05-04 21:21                 ` Scott Wood
2009-05-04 21:57                 ` Wolfgang Denk
2009-05-05  1:36                   ` Shinya Kuribayashi
2009-05-05  9:09                     ` Detlev Zundel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2zle2oz7d.fsf@ohwell.denx.de \
    --to=dzu@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox