From mboxrd@z Thu Jan 1 00:00:00 1970 From: Detlev Zundel Date: Mon, 23 Apr 2007 15:00:17 +0200 Subject: [U-Boot-Users] [patch] Fix NC650 nand support In-Reply-To: <1177285951.26489.5.camel@localhost.localdomain> (Zang Roy-r's message of "23 Apr 2007 07\:52\:31 +0800") References: <20070420154922.3F10B35363E@atlas.denx.de> <1177285951.26489.5.camel@localhost.localdomain> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Roy, > On Fri, 2007-04-20 at 23:49, Wolfgang Denk wrote: >> In message you wrote: > >> [snip] >> > while doing this noticed that the whole fixup only works because we >> > have a maximum of one fixup entry (./drivers/tsi108_pci.c, I cannot >> > find any user of addr_probe anywhere). > Tsi108/9 pci config read will introduce a exception. I do not see other > exception after code relocation. > >> Otherwise the sorting of the >> > table is missing and thus the searching with a bisecting algorithm >> > will not work as is. > Why? As I said, the search algorithm only works with a sorted table - just what "sort_main_extable" does in Linux. To be honest I did not look too hard but I couldn't find anything similar in U-Boot so the table will be unsorted and thus very likely fail if more entries are added. So either sorting the table at some point or instead doing a linear search would fix the problems. Cheers Detlev -- It's very important that you sleep because that's when your brain is garbage collecting. And a dream is if you are interrupted in the middle and have junk left in the registers. -- Gerald Sussman -- DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany +49 8142 66989 40