From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF0AAC433FE for ; Wed, 13 Oct 2021 17:36:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCF17610FE for ; Wed, 13 Oct 2021 17:36:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CCF17610FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fitzsim.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9E116835DE; Wed, 13 Oct 2021 19:36:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=fitzsim.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=fitzsim-org.20210112.gappssmtp.com header.i=@fitzsim-org.20210112.gappssmtp.com header.b="zQTpSDCr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B63FD835DF; Wed, 13 Oct 2021 19:36:06 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 199CE8357B for ; Wed, 13 Oct 2021 19:36:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=fitzsim.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=fitzsim@fitzsim.org Received: by mail-qt1-x82d.google.com with SMTP id r1so3275592qta.12 for ; Wed, 13 Oct 2021 10:36:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zYqZoo6sZGo3ZstfcUtrH91LsLxOvanLsZL6G2T6WtE=; b=zQTpSDCrjqWtY+iJoLx9LLrrswI6zaFTLIcVrBFvnH54svjPpCWjExHbcqjEMcoPAl 5scES82gavgVNEYHydnhdcjTI08Xy2CKwgbGsTQhqWWX8XTqFtN6cc14YlVxAlh284mN CPv6AqjwT6xyhYVWHMsfYzrXdak9MiKf7r07d7dTe/TutCfeo98QpevEsNjYPoUQISI9 fTLT0jEgcAR8elhuhoy/+LQidGuEO6j+Ii6MBgXPgi2sGbgmCFawY7SppmtnHgD20ssi MAH6mkWYzErZcaulHSbOinBCHpRd81FDYuT8oocZsLjnaWvjz0Di9SHzSkkivi598hJd 5NKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zYqZoo6sZGo3ZstfcUtrH91LsLxOvanLsZL6G2T6WtE=; b=EFoyOVGybXQyrKrCcLoO78GKeDl4Yzbs7W94zd6tHTy1XFOM6+Bxku+fj2Gi1d685w RMmvFG5EM6E+PQDBGz/ocwjbYfwuDPcNiSTO8s2JMl1zUsxOVf/DO0BRpMh2Ej2BnmyS MvimOKp3AKiLaPRngIe36cj4QMlbqBCqoOJOR/sDztfqVLFTncKeZR/Hq58QQ7LZGZMp 8OdE7MTsjzDbeeNUULzVMHvKQikXbGUPcAettNbJov284gHka37FmLad3oCrV1m00+RZ IHe8v27jH5kBRPGHTXJ7pC0mFs75tbxCe6vHiF3Tx2XVSWILeIRAO3hGD02UN1/oxSEh spiw== X-Gm-Message-State: AOAM533RFhBSEBNRC/MKPREMkSL+Ha5vxOk7uh8ASFIXQygLuhSTIS+t eAZopKY2l2OHuwEXYcV9GaWWXw== X-Google-Smtp-Source: ABdhPJwWm4FVbOk+Mt8nQVkeQWt0/0SHsIiL4vIpOB+zBmdAfid6rfKaalKbgASsUK7N8VVDc588fA== X-Received: by 2002:ac8:7d81:: with SMTP id c1mr728679qtd.257.1634146561873; Wed, 13 Oct 2021 10:36:01 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id o13sm89670qkl.102.2021.10.13.10.36.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Oct 2021 10:36:01 -0700 (PDT) From: Thomas Fitzsimmons To: Simon Glass Cc: Ilias Apalodimas , Tom Rini , Rick Chen , Leo , Bin Meng , Marek =?utf-8?Q?Beh=C3=BAn?= , Green Wan , Sean Anderson , Lukas Auer , Brad Kim , Zong Li , Heinrich Schuchardt , David Abdurachmanov , Dimitri John Ledkov , U-Boot Mailing List , Mark Kettenis Subject: Re: [PATCH 1/1 RFC] treewide: Deprecate OF_PRIOR_STAGE References: <20210924131021.814662-1-ilias.apalodimas@linaro.org> Date: Wed, 13 Oct 2021 13:36:00 -0400 In-Reply-To: (Simon Glass's message of "Wed, 13 Oct 2021 10:58:13 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Simon Glass writes: [...] > On Wed, 13 Oct 2021 at 10:26, Thomas Fitzsimmons wrote: >> >> Simon Glass writes: >> >> [...] >> >> >> > I think one option is better than two. I have a slight preference for >> >> > OF_PRIOR_STAGE because it is board-agnostic, but I'm not sure it >> >> > matters, since some of these boards are doing strange things anyway >> >> > and cannot use OF_PRIOR_STAGE. So let's go with this. >> >> >> >> For now it's easier getting rid of OF_PRIOR_STAGE than OF_BOARD. >> >> Once we unify OF_PRIOR_STAGE/OF_BOARD and OF_HOSTFILE, then >> >> I can send a patch on top of that, which removes the board_fdt_blob_setup() >> >> and just stores the address in a similar fashion to the removed >> >> 'prior_stage_fdt_address'. That way we can get rid of architecture >> >> specific constructs wrt to DT in gd. The callback is a bit more of a pain to >> >> maintain for multiple boards but is more flexible than an address in a >> >> register. In any case we can do something along the lines of: >> >> >> >> Check register (or blob list or whatever) >> >> if (valid dtb) >> >> fixup/amend/use (depending on what we decide) >> >> else >> >> arch specific callback >> >> >> >> That should give us enough flexibility to deal with future boards (famous >> >> last words). >> > >> > SGTM >> >> This sounds like a good generalization that would still work for the >> bcm7445 and bcm7260 boards. I'll test this approach on the evaluation >> boards I have. >> >> For the BCM7445 I may be able to import the evaluation board device tree >> that Broadcom publishes as part of stblinux. At runtime I may need to >> merge some of the in-memory items generated by BOLT, but I'll try to >> make this work. > > That would be good. > >> The BCM7260 DTS is not publicly available though, as far as I know. > > Presumably it can be dumped from U-Boot? Technically, yes, but I wouldn't want to publish the result for various reasons; e.g., it would be specific to the evaluation boards I have, and it may contain vendor-specific fields. I'd much rather this one remain a stub, until/unless Broadcom publishes a generic BCM7260 DTS under a free license. Thomas