From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A9CC433EF for ; Wed, 13 Oct 2021 16:26:36 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4ED8C61168 for ; Wed, 13 Oct 2021 16:26:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4ED8C61168 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fitzsim.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3326B835CE; Wed, 13 Oct 2021 18:26:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=fitzsim.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=fitzsim-org.20210112.gappssmtp.com header.i=@fitzsim-org.20210112.gappssmtp.com header.b="Chwq8pre"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1797A835D2; Wed, 13 Oct 2021 18:26:32 +0200 (CEST) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B6F308314C for ; Wed, 13 Oct 2021 18:26:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=fitzsim.org Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=fitzsim@fitzsim.org Received: by mail-qk1-x730.google.com with SMTP id q125so2719816qkd.12 for ; Wed, 13 Oct 2021 09:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=vtcIwAXyFUdKXdeO2fbjJbmH/2RW62eBEPUbQO9OUJE=; b=Chwq8preHP0yfS8MCbZveO8cbpGakUAlvhbVdTAmufXKo/HqyoHcpjDTxMHGiEv5pI s34XJA+vA1BNo8ESG5GUiYP2sl9uWHbpMa/ZSRJhvh2pv7iKpFp4iGlR2uf3AaSAgDgY WQWM/4nqcV8+naJjdGRtYAwWecH4sNsvyDL9Tw7E57uaqFIqwMfqdDNH6C7Oapyliuj8 kD7Ksz2g4SaBGtopqhJsw8qinCllr4igWeoIe5KGOni+5s4nIJyLmOEPXh9skvjfCMkp gmyBsRaAehQ+jZjZ1q6Iz5AhzntyN4b2OP0mggNcdJcuCbq+TbB0eoE6LdzHnSZTwypk 1Z7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=vtcIwAXyFUdKXdeO2fbjJbmH/2RW62eBEPUbQO9OUJE=; b=hD0DN+fQwNqhR07z8TqCjE9deNNolVAgadIbcVBgH/a9XwkzHU4rVksto9xRonzEAV jXzfaq1Ew9etxNxzS8s4S5LmBrmkYCqLCU9PRZzpSLQczyV1x0zmLtVaPKUHxO3RkMEg M3PyBiDQ0cHGrI8ESxQjt5HpxlxmKr2zuJwiLtMgbymQnBiGA0zUe6aV9/xNby/CJNV8 TMtLO4EK0awhyLK27K7NJx3aHNzSqTB6bYf9zLv+AHQTXTeDJoUNnWRgtDolG4Iy0OCp FaUzWIkv8f5MIhFnFX8n8hpULj7EDAuFQxtdNPU3JYYIkpe99CwTnTqoOV35TXdOBVVe GfAg== X-Gm-Message-State: AOAM530phG+JIp0v6brBIAnnvCP6pKLhdi52Qg2J0mLlx/NGhFkIkT4O muMCISVh4f9BJp25LB8+TYpcCQ== X-Google-Smtp-Source: ABdhPJwJllWhuUGnVFwNA4n4jVkYNL7PYGQALHT3myiRfdHpimIKvJtook9JO8Yy1eFvcjTLoB25fA== X-Received: by 2002:a37:b606:: with SMTP id g6mr215062qkf.328.1634142387661; Wed, 13 Oct 2021 09:26:27 -0700 (PDT) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id t26sm49856qtq.77.2021.10.13.09.26.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Oct 2021 09:26:27 -0700 (PDT) From: Thomas Fitzsimmons To: Simon Glass Cc: Ilias Apalodimas , Tom Rini , Rick Chen , Leo , Bin Meng , Marek =?utf-8?Q?Beh=C3=BAn?= , Green Wan , Sean Anderson , Lukas Auer , Brad Kim , Zong Li , Heinrich Schuchardt , David Abdurachmanov , Dimitri John Ledkov , U-Boot Mailing List , Mark Kettenis Subject: Re: [PATCH 1/1 RFC] treewide: Deprecate OF_PRIOR_STAGE References: <20210924131021.814662-1-ilias.apalodimas@linaro.org> Date: Wed, 13 Oct 2021 12:26:25 -0400 In-Reply-To: (Simon Glass's message of "Fri, 24 Sep 2021 10:07:37 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Simon Glass writes: [...] >> > I think one option is better than two. I have a slight preference for >> > OF_PRIOR_STAGE because it is board-agnostic, but I'm not sure it >> > matters, since some of these boards are doing strange things anyway >> > and cannot use OF_PRIOR_STAGE. So let's go with this. >> >> For now it's easier getting rid of OF_PRIOR_STAGE than OF_BOARD. >> Once we unify OF_PRIOR_STAGE/OF_BOARD and OF_HOSTFILE, then >> I can send a patch on top of that, which removes the board_fdt_blob_setup() >> and just stores the address in a similar fashion to the removed >> 'prior_stage_fdt_address'. That way we can get rid of architecture >> specific constructs wrt to DT in gd. The callback is a bit more of a pain to >> maintain for multiple boards but is more flexible than an address in a >> register. In any case we can do something along the lines of: >> >> Check register (or blob list or whatever) >> if (valid dtb) >> fixup/amend/use (depending on what we decide) >> else >> arch specific callback >> >> That should give us enough flexibility to deal with future boards (famous >> last words). > > SGTM This sounds like a good generalization that would still work for the bcm7445 and bcm7260 boards. I'll test this approach on the evaluation boards I have. For the BCM7445 I may be able to import the evaluation board device tree that Broadcom publishes as part of stblinux. At runtime I may need to merge some of the in-memory items generated by BOLT, but I'll try to make this work. The BCM7260 DTS is not publicly available though, as far as I know. Thomas