From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74A85C77B7E for ; Mon, 29 May 2023 13:13:49 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 53F1C84775; Mon, 29 May 2023 15:13:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="PEkEExms"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E6E778476C; Mon, 29 May 2023 15:13:44 +0200 (CEST) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5A8658565A for ; Mon, 29 May 2023 15:13:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rui.silva@linaro.org Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3f60804faf4so20792225e9.3 for ; Mon, 29 May 2023 06:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685366022; x=1687958022; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=DVa/w4Va19esVIdZxbGHibE66Un+gzPVkuUP9TAv6TA=; b=PEkEExmsoT+xAzFGv0Ce8u+P4Q2BcOosomzsq2YRKKcm3LSlBpQkXiiG6dBYgWDMxO sqJlH9bAUEkA74nQ+681srvkOZDrADpO637GmQ5tlMC0pWNV3V+HRJdWH5t97/MGJPYT 4vsfAB9533AoaRTNGGkuBXYJmLU74OVqqEJ4Qk9YrkTLol2lNVM3bhlj3fv1YutKaoTZ BkOirYN0oMldtsEK79g48kSMlGtqBu85TD9aoUZA94Byvs0pYXQKOUEZVWnwto4cKXBj hQ25yztV5gap6ZrzlyPrx4D6Xo1EohP4LTy+IwL473XvvQAJb93nGWQFAnMMDF2d7ARV nO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685366022; x=1687958022; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DVa/w4Va19esVIdZxbGHibE66Un+gzPVkuUP9TAv6TA=; b=jLgA85I4PlNwvS7y9YFdrNZ3K4RYzm9uGV3LCl3odO1wKkUAsNdyOQZ5Hjh8ahuOGC c8rzy9gI/Qnj2R3jdQ/q3oAaz7YFw+GpGnlENN9sah1NoKeV6R1f8/Ot1hr7Ej831oEf m3EX0nsF+hkDCoZIqAiolAIzlES1qiDh5V+SlDSWDTrmkxIZ4pQYxcB8paDqtIWRV3gO VS7YXcDWVNcyOgJucx/BVACGhf/0vtp3REvL7RrPijeqpx3/f7OGRQbAErJ4z9r7wHvv d2xTp8P5ZJ/D1a95vi907OJspL785w3POD4iH13R8RmcChe/nV8ll406vPOnFRcBd9BS pXIA== X-Gm-Message-State: AC+VfDzJg4kTzXT/u3uKEoSeViw8WMxwZwoOu3Ljf8aCBkV2u1DUpViD Y2lEFE49YxE7NeGAEyjyVMN4gA== X-Google-Smtp-Source: ACHHUZ7T90oH1wRxEVsn7VF9U0/nyT1lCr6Cocsh04RScGuDO/a5JUZcN8S66c6bVryjgjRPvq+eWg== X-Received: by 2002:a7b:cc95:0:b0:3f5:1a4:a08d with SMTP id p21-20020a7bcc95000000b003f501a4a08dmr10579866wma.7.1685366021832; Mon, 29 May 2023 06:13:41 -0700 (PDT) Received: from localhost (a109-49-33-111.cpe.netcabo.pt. [109.49.33.111]) by smtp.gmail.com with ESMTPSA id m8-20020a7bce08000000b003f17af4c4e0sm17934556wmc.9.2023.05.29.06.13.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 06:13:41 -0700 (PDT) From: Rui Miguel Silva To: Heinrich Schuchardt Cc: Simon Glass , Tom Rini , Ilias Apalodimas , u-boot@lists.denx.de Subject: Re: [PATCH 2/6] nvmxip: move header to include In-Reply-To: References: <20230502131200.2551513-1-rui.silva@linaro.org> <20230502131200.2551513-3-rui.silva@linaro.org> Date: Mon, 29 May 2023 14:13:40 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich, Thanks for the review. Heinrich Schuchardt writes: > On 5/2/23 15:11, Rui Miguel Silva wrote: >> Move header to include to allow external code >> to get the internal bdev structures to access >> block device operations. >> >> as at it, just add the UCLASS_NVMXIP string >> so we get the correct output in partitions >> listing. >> >> Signed-off-by: Rui Miguel Silva >> --- >> {drivers/mtd/nvmxip => include}/nvmxip.h | 0 >> 1 file changed, 0 insertions(+), 0 deletions(-) >> rename {drivers/mtd/nvmxip => include}/nvmxip.h (100%) >> >> diff --git a/drivers/mtd/nvmxip/nvmxip.h b/include/nvmxip.h >> similarity index 100% >> rename from drivers/mtd/nvmxip/nvmxip.h >> rename to include/nvmxip.h > > We expect the code to compile after each single patch. Otherwise > bisecting will not work. > > You cannot move an include without adjusting all references, e.g. > test/dm/nvmxip.c:20:#include "../../drivers/mtd/nvmxip/nvmxip.h" Hrrr, thanks for noticing this. I will fix it in v2. Cheers, Rui > > Best regards > > Heinrich