[PATCH] spi: spi-mem: s/dummy/data buswidth check in dtr_supports_op()

[PATCH] spi: spi-mem: s/dummy/data buswidth check in dtr_supports_op()

[Dhruva Gole]

This should have been op->data.buswidth instead as we check for octal
bus width for the data related ops
Also add explanation for why there is checks for 8D even data bytes

Cc: Pratyush Yadav <pratyush@kernel.org>
Signed-off-by: Dhruva Gole <d-gole@ti.com>
---

Address Pratyush Yadav's comments from here:
https://lore.kernel.org/u-boot/20221106224617.2ievqx37mcvqntdr@yadavpratyush.com/

 drivers/spi/spi-mem.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
index 8e8995fc537f..57a36f31a5d3 100644
--- a/drivers/spi/spi-mem.c
+++ b/drivers/spi/spi-mem.c
@@ -181,8 +181,12 @@ bool spi_mem_dtr_supports_op(struct spi_slave *slave,
 	if (op->dummy.nbytes && op->dummy.buswidth == 8 && op->dummy.nbytes % 2)
 		return false;
 
+	/*
+	 * Transactions of odd length do not make sense for 8D-8D-8D mode
+	 * because a byte is transferred in just half a cycle.
+	 */
 	if (op->data.dir != SPI_MEM_NO_DATA &&
-	    op->dummy.buswidth == 8 && op->data.nbytes % 2)
+	    op->data.buswidth == 8 && op->data.nbytes % 2)
 		return false;
 
 	return spi_mem_check_buswidth(slave, op);
-- 
2.25.1

Re: [PATCH] spi: spi-mem: s/dummy/data buswidth check in dtr_supports_op()

[Pratyush Yadav]

On Mon, Feb 20 2023, Dhruva Gole wrote:

> This should have been op->data.buswidth instead as we check for octal
> bus width for the data related ops
> Also add explanation for why there is checks for 8D even data bytes
>
> Cc: Pratyush Yadav <pratyush@kernel.org>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>

Reviewed-by: Pratyush Yadav <ptyadav@amazon.de>

> ---
>
> Address Pratyush Yadav's comments from here:
> https://lore.kernel.org/u-boot/20221106224617.2ievqx37mcvqntdr@yadavpratyush.com/
>
>  drivers/spi/spi-mem.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
> index 8e8995fc537f..57a36f31a5d3 100644
> --- a/drivers/spi/spi-mem.c
> +++ b/drivers/spi/spi-mem.c
> @@ -181,8 +181,12 @@ bool spi_mem_dtr_supports_op(struct spi_slave *slave,
>         if (op->dummy.nbytes && op->dummy.buswidth == 8 && op->dummy.nbytes % 2)
>                 return false;
>
> +       /*
> +        * Transactions of odd length do not make sense for 8D-8D-8D mode
> +        * because a byte is transferred in just half a cycle.
> +        */
>         if (op->data.dir != SPI_MEM_NO_DATA &&
> -           op->dummy.buswidth == 8 && op->data.nbytes % 2)
> +           op->data.buswidth == 8 && op->data.nbytes % 2)
>                 return false;
>
>         return spi_mem_check_buswidth(slave, op);
> --
> 2.25.1
>

-- 
Regards,
Pratyush Yadav



Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879