From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4331CC6FD1C for ; Thu, 23 Mar 2023 08:31:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3211D85925; Thu, 23 Mar 2023 09:31:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="jnRl1GHd"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="+gcITsc9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3367985925; Thu, 23 Mar 2023 09:31:33 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F071385A1B for ; Thu, 23 Mar 2023 09:31:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=schwab@suse.de Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id A328C3441D; Thu, 23 Mar 2023 08:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679560289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pkO6Wegy098XMaK7MlQmyTnF6t2G2bfDpxkZ/qg3z7Q=; b=jnRl1GHdttxHYKW80nNal4Mvla0MzZI5QSRVHdGAZQjHfY8c3yZscjPMPJO5zlbU0eSA+X 8MdyS4aeshTpK3yI3Zh5M2SGaffi6VoU6+nhMVYMWHJAhiICJuin1BK8SUyitJMsnP5Hdr 3W1IcLps16p5cAm8jMmv/HwZ6+EPWDE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679560289; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pkO6Wegy098XMaK7MlQmyTnF6t2G2bfDpxkZ/qg3z7Q=; b=+gcITsc9tPK08ZYkFN5H4Q8Qf4tor62vi3cH1v3MApdq9Axat6UK+jGNQUeqo680RBhP6O q53wiZdfAkbb98AQ== Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 4DBC22C141; Thu, 23 Mar 2023 08:31:29 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id EAB824A0358; Thu, 23 Mar 2023 09:31:28 +0100 (CET) From: Andreas Schwab To: yanhong wang Cc: , Rick Chen , Leo , Lukasz Majewski , Sean Anderson , Lee Kuan Lim , "Jianlong Huang" , Emil Renner Berthing Subject: Re: [PATCH v4 17/17] configs: starfive: add starfive_visionfive2_defconfig References: <20230316025332.3297-1-yanhong.wang@starfivetech.com> <20230316025332.3297-18-yanhong.wang@starfivetech.com> <25a31500-01c2-86c0-77fc-d8ba68c81a5d@starfivetech.com> <2a2021ee-2129-52e3-c570-a5d2e1bf8a66@starfivetech.com> X-Yow: I'm mentally OVERDRAWN! What's that SIGNPOST up ahead? Where's ROD STERLING when you really need him? Date: Thu, 23 Mar 2023 09:31:28 +0100 In-Reply-To: <2a2021ee-2129-52e3-c570-a5d2e1bf8a66@starfivetech.com> (yanhong wang's message of "Wed, 22 Mar 2023 09:22:53 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mär 22 2023, yanhong wang wrote: > On 2023/3/21 21:51, Andreas Schwab wrote: >> On Mär 21 2023, yanhong wang wrote: >> >>> Except for CONFIG_DEFAULT_DEVICE_TREE and CONFIG_DEFAULT_FDT_FILE, >>> 1.2a and 1.3b versions use the same config. >>> >>> Version 1.3b uses the following configuration: >>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.3b" >>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.3b.dtb" >>> >>> Version 1.2a uses the following configuration: >>> CONFIG_DEFAULT_DEVICE_TREE="jh7110-starfive-visionfive-2-v1.2a" >>> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2-v1.2a.dtb" >>> >>> Is it necessary to separate the configs for 1.2a and 1.3b as separate defconfig files? >> >> It makes a difference for when ethernet support is added. >> > > The difference between 1.2a and 1.3b versions is mainly in ethernet, so the definition of > dts is separated. Defconfig file in addition to the differences mentioned above, the others > are the same. Your suggestion is to define defconfig file separately, is that right? Yes, a 1.2a board will need to use the 1.2a device tree to get a working ethernet, IIUC. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."