[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[Matwey V. Kornilov]

Hello,

I am running 2016.01-rc on BBB (Embest replica)

printenv shows the following:

findfdt=if test $board_name = A335BONE; then setenv fdtfile
am335x-bone.dtb; fi; if test $board_name = A335BNLT; then if test
$board_rev = BBG1; then setenv fdtfile am335x-bonegreen.dtb; else setenv
fdtfile am335x-boneblack.dtb; fi; fi; if test $board_name = A33515BB;
then setenv fdtfile am335x-evm.dtb; fi; if test $board_name = A335X_SK;
then setenv fdtfile am335x-evmsk.dtb; fi; if test $fdtfile = undefined;
then echo WARNING: Could not determine device tree to use; fi;

after findfdt has been run,

fdtfile=am335x-bonegreen.dtb

But it is not correct. My $board_rev is the following, I have no idea
why does it contain line break.

board_name=A335BNLT
board_rev=t\
ue

[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[Robert Nelson]

Hi Matwey

On Sat, Dec 12, 2015 at 3:14 AM, Matwey V. Kornilov
<matwey.kornilov@gmail.com> wrote:
> Hello,
>
> I am running 2016.01-rc on BBB (Embest replica)
>
> printenv shows the following:
>
> findfdt=if test $board_name = A335BONE; then setenv fdtfile
> am335x-bone.dtb; fi; if test $board_name = A335BNLT; then if test
> $board_rev = BBG1; then setenv fdtfile am335x-bonegreen.dtb; else setenv
> fdtfile am335x-boneblack.dtb; fi; fi; if test $board_name = A33515BB;
> then setenv fdtfile am335x-evm.dtb; fi; if test $board_name = A335X_SK;
> then setenv fdtfile am335x-evmsk.dtb; fi; if test $fdtfile = undefined;
> then echo WARNING: Could not determine device tree to use; fi;
>
> after findfdt has been run,
>
> fdtfile=am335x-bonegreen.dtb
>
> But it is not correct. My $board_rev is the following, I have no idea
> why does it contain line break.
>
> board_name=A335BNLT
> board_rev=t\

Yuck, another variation!  Can you do me a favor and dump the eeprom:

https://github.com/beagleboard/image-builder/blob/master/readme.md

Download and run:

wget https://raw.githubusercontent.com/RobertCNelson/boot-scripts/master/device/bone/tester/show-eeprom.sh

sudo /bin/bash show-eeprom.sh

It uses hexdump and compatible with bb.org' 3.8/4.1/etc..

The green should only trigger on: 0x1a 0x00 0x00 0x00

http://git.denx.de/?p=u-boot.git;a=blobdiff;f=board/ti/am335x/board.c;h=f56d17ec58e17a6532b5df649249b4038b475897;hp=f0cb1e204ad550622df7848a993f1eb2f173bc43;hb=dfd1bb4ec89e8b1e87f0605af2345ad6dcf777da;hpb=e4aa8edb6e5cae256a5c5a3c5cd30e05e8f5a2b4

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[Matwey V. Kornilov]

2015-12-17 3:53 GMT+03:00 Robert Nelson <robertcnelson@gmail.com>:
> Hi Matwey
>
> On Sat, Dec 12, 2015 at 3:14 AM, Matwey V. Kornilov
> <matwey.kornilov@gmail.com> wrote:
>> Hello,
>>
>> I am running 2016.01-rc on BBB (Embest replica)
>>
>> printenv shows the following:
>>
>> findfdt=if test $board_name = A335BONE; then setenv fdtfile
>> am335x-bone.dtb; fi; if test $board_name = A335BNLT; then if test
>> $board_rev = BBG1; then setenv fdtfile am335x-bonegreen.dtb; else setenv
>> fdtfile am335x-boneblack.dtb; fi; fi; if test $board_name = A33515BB;
>> then setenv fdtfile am335x-evm.dtb; fi; if test $board_name = A335X_SK;
>> then setenv fdtfile am335x-evmsk.dtb; fi; if test $fdtfile = undefined;
>> then echo WARNING: Could not determine device tree to use; fi;
>>
>> after findfdt has been run,
>>
>> fdtfile=am335x-bonegreen.dtb
>>
>> But it is not correct. My $board_rev is the following, I have no idea
>> why does it contain line break.
>>
>> board_name=A335BNLT
>> board_rev=t\
>
> Yuck, another variation!  Can you do me a favor and dump the eeprom:
>
> https://github.com/beagleboard/image-builder/blob/master/readme.md
>
> Download and run:
>
> wget https://raw.githubusercontent.com/RobertCNelson/boot-scripts/master/device/bone/tester/show-eeprom.sh
>
> sudo /bin/bash show-eeprom.sh

# sudo /bin/bash show-eeprom.sh
eeprom: [?U3?A335BNLTt
ue]
eeprom raw: [00000000  aa 55 33 ee 41 33 33 35  42 4e 4c 54 74 0a 75
65  |.U3.A335BNLTt.ue|]


>
> It uses hexdump and compatible with bb.org' 3.8/4.1/etc..
>
> The green should only trigger on: 0x1a 0x00 0x00 0x00
>
> http://git.denx.de/?p=u-boot.git;a=blobdiff;f=board/ti/am335x/board.c;h=f56d17ec58e17a6532b5df649249b4038b475897;hp=f0cb1e204ad550622df7848a993f1eb2f173bc43;hb=dfd1bb4ec89e8b1e87f0605af2345ad6dcf777da;hpb=e4aa8edb6e5cae256a5c5a3c5cd30e05e8f5a2b4
>
> Regards,
>
> --
> Robert Nelson
> https://rcn-ee.com/



-- 
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp://0x2207 at jabber.ru

[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[Robert Nelson]

On Thu, Dec 17, 2015 at 11:54 AM, Matwey V. Kornilov
<matwey.kornilov@gmail.com> wrote:
> 2015-12-17 3:53 GMT+03:00 Robert Nelson <robertcnelson@gmail.com>:
>> Hi Matwey
>>
>> On Sat, Dec 12, 2015 at 3:14 AM, Matwey V. Kornilov
>> <matwey.kornilov@gmail.com> wrote:
>>> Hello,
>>>
>>> I am running 2016.01-rc on BBB (Embest replica)
>>>
>>> printenv shows the following:
>>>
>>> findfdt=if test $board_name = A335BONE; then setenv fdtfile
>>> am335x-bone.dtb; fi; if test $board_name = A335BNLT; then if test
>>> $board_rev = BBG1; then setenv fdtfile am335x-bonegreen.dtb; else setenv
>>> fdtfile am335x-boneblack.dtb; fi; fi; if test $board_name = A33515BB;
>>> then setenv fdtfile am335x-evm.dtb; fi; if test $board_name = A335X_SK;
>>> then setenv fdtfile am335x-evmsk.dtb; fi; if test $fdtfile = undefined;
>>> then echo WARNING: Could not determine device tree to use; fi;
>>>
>>> after findfdt has been run,
>>>
>>> fdtfile=am335x-bonegreen.dtb
>>>
>>> But it is not correct. My $board_rev is the following, I have no idea
>>> why does it contain line break.
>>>
>>> board_name=A335BNLT
>>> board_rev=t\
>>
>> Yuck, another variation!  Can you do me a favor and dump the eeprom:
>>
>> https://github.com/beagleboard/image-builder/blob/master/readme.md
>>
>> Download and run:
>>
>> wget https://raw.githubusercontent.com/RobertCNelson/boot-scripts/master/device/bone/tester/show-eeprom.sh
>>
>> sudo /bin/bash show-eeprom.sh
>
> # sudo /bin/bash show-eeprom.sh
> eeprom: [?U3?A335BNLTt
> ue]
> eeprom raw: [00000000  aa 55 33 ee 41 33 33 35  42 4e 4c 54 74 0a 75
> 65  |.U3.A335BNLTt.ue|]

ah, it's tripping on the "." = "0a" character..

Do you happen to remember where you purchased it and what it was
called.. (for git commit)

This patch should work:

https://gist.github.com/RobertCNelson/21f44591c78daed7c637

Please test,

and i've added it to our table:

https://github.com/RobertCNelson/omap-image-builder/commit/620ebf627d3df8c693845bef07af232aa289ff41

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[Matwey V. Kornilov]

2015-12-17 21:08 GMT+03:00 Robert Nelson <robertcnelson@gmail.com>:
> On Thu, Dec 17, 2015 at 11:54 AM, Matwey V. Kornilov
> <matwey.kornilov@gmail.com> wrote:
>> 2015-12-17 3:53 GMT+03:00 Robert Nelson <robertcnelson@gmail.com>:
>>> Hi Matwey
>>>
>>> On Sat, Dec 12, 2015 at 3:14 AM, Matwey V. Kornilov
>>> <matwey.kornilov@gmail.com> wrote:
>>>> Hello,
>>>>
>>>> I am running 2016.01-rc on BBB (Embest replica)
>>>>
>>>> printenv shows the following:
>>>>
>>>> findfdt=if test $board_name = A335BONE; then setenv fdtfile
>>>> am335x-bone.dtb; fi; if test $board_name = A335BNLT; then if test
>>>> $board_rev = BBG1; then setenv fdtfile am335x-bonegreen.dtb; else setenv
>>>> fdtfile am335x-boneblack.dtb; fi; fi; if test $board_name = A33515BB;
>>>> then setenv fdtfile am335x-evm.dtb; fi; if test $board_name = A335X_SK;
>>>> then setenv fdtfile am335x-evmsk.dtb; fi; if test $fdtfile = undefined;
>>>> then echo WARNING: Could not determine device tree to use; fi;
>>>>
>>>> after findfdt has been run,
>>>>
>>>> fdtfile=am335x-bonegreen.dtb
>>>>
>>>> But it is not correct. My $board_rev is the following, I have no idea
>>>> why does it contain line break.
>>>>
>>>> board_name=A335BNLT
>>>> board_rev=t\
>>>
>>> Yuck, another variation!  Can you do me a favor and dump the eeprom:
>>>
>>> https://github.com/beagleboard/image-builder/blob/master/readme.md
>>>
>>> Download and run:
>>>
>>> wget https://raw.githubusercontent.com/RobertCNelson/boot-scripts/master/device/bone/tester/show-eeprom.sh
>>>
>>> sudo /bin/bash show-eeprom.sh
>>
>> # sudo /bin/bash show-eeprom.sh
>> eeprom: [?U3?A335BNLTt
>> ue]
>> eeprom raw: [00000000  aa 55 33 ee 41 33 33 35  42 4e 4c 54 74 0a 75
>> 65  |.U3.A335BNLTt.ue|]
>
> ah, it's tripping on the "." = "0a" character..
>
> Do you happen to remember where you purchased it and what it was
> called.. (for git commit)
>
> This patch should work:
>
> https://gist.github.com/RobertCNelson/21f44591c78daed7c637
>

The patch works good.
But could you please explain me? I thought the problem was in 'test' operator.
Unlikely
test '\0x74\0x0a\0x75\0x65' = BBG1
should be true.

> Please test,
>
> and i've added it to our table:
>
> https://github.com/RobertCNelson/omap-image-builder/commit/620ebf627d3df8c693845bef07af232aa289ff41
>
> Regards,
>
> --
> Robert Nelson
> https://rcn-ee.com/



-- 
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp://0x2207 at jabber.ru

[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[Robert Nelson]

>> ah, it's tripping on the "." = "0a" character..
>>
>> Do you happen to remember where you purchased it and what it was
>> called.. (for git commit)
>>
>> This patch should work:
>>
>> https://gist.github.com/RobertCNelson/21f44591c78daed7c637
>>
>
> The patch works good.
> But could you please explain me? I thought the problem was in 'test' operator.
> Unlikely
> test '\0x74\0x0a\0x75\0x65' = BBG1
> should be true.

I saw this when i first booted the Green with the production eeprom,
"test" doesn't seem to like non printable characters..

Sorry i didn't look into "test" much further..

Instead i just worked around it with the Green..

Regards,

-- 
Robert Nelson
https://rcn-ee.com/

[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[Matwey V. Kornilov]

2015-12-20 1:29 GMT+03:00 Robert Nelson <robertcnelson@gmail.com>:
>>> ah, it's tripping on the "." = "0a" character..
>>>
>>> Do you happen to remember where you purchased it and what it was
>>> called.. (for git commit)
>>>
>>> This patch should work:
>>>
>>> https://gist.github.com/RobertCNelson/21f44591c78daed7c637
>>>
>>
>> The patch works good.
>> But could you please explain me? I thought the problem was in 'test' operator.
>> Unlikely
>> test '\0x74\0x0a\0x75\0x65' = BBG1
>> should be true.
>
> I saw this when i first booted the Green with the production eeprom,
> "test" doesn't seem to like non printable characters..

Seems, issue is in command parser, not in test itself.

>
> Sorry i didn't look into "test" much further..
>
> Instead i just worked around it with the Green..
>
> Regards,
>
> --
> Robert Nelson
> https://rcn-ee.com/



-- 
With best regards,
Matwey V. Kornilov
http://blog.matwey.name
xmpp://0x2207 at jabber.ru

[U-Boot] u-boot 2016.01-rc2 detects BeagleBone Black incorrectly

[Tom Rini]

On Sun, Dec 20, 2015 at 12:57:33PM +0300, Matwey V. Kornilov wrote:
> 2015-12-20 1:29 GMT+03:00 Robert Nelson <robertcnelson@gmail.com>:
> >>> ah, it's tripping on the "." = "0a" character..
> >>>
> >>> Do you happen to remember where you purchased it and what it was
> >>> called.. (for git commit)
> >>>
> >>> This patch should work:
> >>>
> >>> https://gist.github.com/RobertCNelson/21f44591c78daed7c637
> >>>
> >>
> >> The patch works good.
> >> But could you please explain me? I thought the problem was in 'test' operator.
> >> Unlikely
> >> test '\0x74\0x0a\0x75\0x65' = BBG1
> >> should be true.
> >
> > I saw this when i first booted the Green with the production eeprom,
> > "test" doesn't seem to like non printable characters..
> 
> Seems, issue is in command parser, not in test itself.

Yeah.  You may be able to instead use 'cmp.w' and mw to try and keep all
of this inside just the script side of things and outside of C.  That
also however may end up being even uglier.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151220/88c583c0/attachment.sig>