From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A534CF364A6 for ; Thu, 9 Apr 2026 18:12:53 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8EABA84167; Thu, 9 Apr 2026 20:12:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=postmarketos.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=postmarketos.org header.i=@postmarketos.org header.b="RZlMw3fJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0F55B84099; Thu, 9 Apr 2026 19:43:58 +0200 (CEST) Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [IPv6:2001:41d0:1004:224b::aa]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C7D9A83D8A for ; Thu, 9 Apr 2026 19:43:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=postmarketos.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=funderscore@postmarketos.org Date: Thu, 09 Apr 2026 17:38:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=postmarketos.org; s=key1; t=1775756633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tw/J9VRpjgEKX+sgPsRv04aZlKhkiyBr/oxQ6MnS1bg=; b=RZlMw3fJ+eCpXpvC5jlqo2dG65t3zCSyvXo5Hp/l3YUKa5FuZpvex+WlYOdO6W7yjO0DST XpI8pCfaBxwo0Zqe0JBJzWb0RBJPeVgTXlwmUFjw/JO14xSAh5PS7FAbxMhfK9IkApUuZT 0U1DXqsO74u8r/RYuRg17DCcj/FQNlpYgH4w3zOG67yQGbEjs6n/Bc23muD4pJKfSnWrkK Lq56PsbPwjt9mXu5XZUSYyZMV9AYb26ccoTzBX3bPplw6zHWri5WavN4chGqXey+4c60fR Rakd6iksN7pLh7lOK0dhrkXlbkL3EDR/TYJjfx4odwyiS2ESDk8RxwnWjIkRWA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ferass El Hafidi To: u-boot-qcom@groups.io, u-boot@lists.denx.de, Sumit Garg Cc: Tom Rini , Neil Armstrong , Bhupesh Sharma , Neha Malcom Francis , Anshul Dalal , Peng Fan , Mattijs Korpershoek , Quentin Schulz , Hrushikesh Salunke , Alexey Charkov , Dario Binacchi , Andre Przywara , Ilias Apalodimas , Javier Martinez Canillas , Jan Kiszka , Javier Tia , Rasmus Villemoes , Varadarajan Narayanan , Jo=?UTF-8?B?w6M=?=o Marcos Costa , Dhruva Gole , Richard Genoud , Marek Vasut , Simon Glass , Igor Belwon , Shawn Lin , Tuyen Dang , Casey Connolly , Lukasz Majewski , Patrice Chotard , Patrick Delaunay , Michal Simek , Yao Zi , Peter Korsgaard , Balaji Selvanathan Subject: Re: [PATCH 2/4] drivers: ufs: qcom: Add SPL support References: <20260409-spl_ufs_only-v1-0-f7e0e243d805@oss.qualcomm.com> <20260409-spl_ufs_only-v1-2-f7e0e243d805@oss.qualcomm.com> In-Reply-To: <20260409-spl_ufs_only-v1-2-f7e0e243d805@oss.qualcomm.com> Message-ID: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8; format=flowed X-Migadu-Flow: FLOW_OUT X-Mailman-Approved-At: Thu, 09 Apr 2026 20:12:23 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, some drive-by feedback: On Thu, 09 Apr 2026 14:43, "Balaji Selvanathan via groups.io" wrote: >Enable Qualcomm UFS driver to be built for SPL. The ufs-uclass is >also built conditionally based on whether SPL or >U-Boot proper is being compiled. > >Signed-off-by: Balaji Selvanathan >--- > drivers/ufs/Kconfig | 8 ++++++++ > drivers/ufs/Makefile | 7 ++++++- > 2 files changed, 14 insertions(+), 1 deletion(-) > >diff --git a/drivers/ufs/Kconfig b/drivers/ufs/Kconfig >index 49472933de3..a32d51cae1d 100644 >--- a/drivers/ufs/Kconfig >+++ b/drivers/ufs/Kconfig >@@ -55,6 +55,14 @@ config UFS_QCOM > This selects the platform driver for the UFS host > controller present on Qualcomm Snapdragon SoCs. > >+config SPL_UFS_QCOM >+ bool "Qualcomm Host Controller driver for UFS in SPL" >+ depends on SPL_UFS_SUPPORT && ARCH_SNAPDRAGON >+ help >+ This selects the platform driver for the UFS host >+ controller present on Qualcomm Snapdragon SoCs for use in SPL. >+ Enable this to use UFS as a boot device in SPL on Qualcomm platforms. >+ > config UFS_RENESAS > bool "Renesas R-Car S4 UFS Controller support" > depends on UFS >diff --git a/drivers/ufs/Makefile b/drivers/ufs/Makefile >index e7f3c1d30c4..7056066ce25 100644 >--- a/drivers/ufs/Makefile >+++ b/drivers/ufs/Makefile >@@ -3,13 +3,18 @@ > # Copyright (C) 2019 Texas Instruments Incorporated - https://www.ti.com > # > >+ifdef CONFIG_SPL_BUILD >+obj-$(CONFIG_SPL_UFS_SUPPORT) += ufs-uclass.o >+else > obj-$(CONFIG_UFS) += ufs-uclass.o >+endif CONFIG_SPL_UFS_SUPPORT depends on CONFIG_UFS being enabled, so from my understanding, don't think this change is needed, is it? > obj-$(CONFIG_UFS_AMD_VERSAL2) += ufs-amd-versal2.o ufshcd-dwc.o > obj-$(CONFIG_UFS_CADENCE) += cdns-platform.o > obj-$(CONFIG_UFS_MEDIATEK) += ufs-mediatek.o > obj-$(CONFIG_UFS_PCI) += ufs-pci.o >-obj-$(CONFIG_UFS_QCOM) += ufs-qcom.o >+obj-$(CONFIG_$(PHASE_)UFS_QCOM) += ufs-qcom.o > obj-$(CONFIG_UFS_RENESAS) += ufs-renesas.o > obj-$(CONFIG_UFS_RENESAS_GEN5) += ufs-renesas-rcar-gen5.o > obj-$(CONFIG_UFS_ROCKCHIP) += ufs-rockchip.o > obj-$(CONFIG_UFS_TI_J721E) += ti-j721e-ufs.o >+ > Best regards, Ferass