[U-Boot-Users] smc91111.c : error: label at end of compound statement

[U-Boot-Users] smc91111.c : error: label at end of compound statement

[Komal Shah]

Hi All,

I have tried to cross-compile (arm-linux-gcc-3.4.0)
u-boot source-code with smc91111.c driver enabled. I
am getting this error, because of recent changes in
gcc-3.4.x series to detect them. 

----------snip--------------
arm-linux-gcc -g  -Os   -fno-strict-aliasing 
-fno-common -ffixed-r8  -D__KERNEL__
-DTEXT_BASE=0x80e80000 -I/home/bluesky/u-boot/include
-fno-builtin -ffreestanding -nostdinc -isystem
/public/data/omapts/linux/arm-tc/gcc-3.4.0-1/bin/../lib/gcc/arm-linux/3.4.0/include
-pipe  -DCONFIG_ARM -D__ARM__ -mapcs-32 -march=armv6
-Wall -Wstrict-prototypes -c -o smc91111.o smc91111.c
smc91111.c: In function `smc_phy_configure':
smc91111.c:1343: error: label at end of compound
statement
make[1]: *** [smc91111.o] Error 1
make[1]: Leaving directory
`/home/bluesky/u-boot/drivers'
make: *** [drivers/libdrivers.a] Error 2
----------snip--------------

code snippet:
----------snip--------------
        /* Re-Configure the Receive/Phy Control
register */
        SMC_outw (RPC_DEFAULT, RPC_REG);

      smc_phy_configure_exit:
}
----------snip--------------

It seems to me that no one there tried the above
combination. Simple solution is to put some dummy
varibale initialisation _or_ is there any compiler
switch to make it as warning. 



=====
---Komal Shah


		
__________________________________ 
Do you Yahoo!? 
Yahoo! Mail - now with 250MB free storage. Learn more.
http://info.mail.yahoo.com/mail_250

[U-Boot-Users] smc91111.c : error: label at end of compound statement

[Wolfgang Denk]

In message <20050127063951.66064.qmail@web53603.mail.yahoo.com> you wrote:
> 
> I have tried to cross-compile (arm-linux-gcc-3.4.0)
> u-boot source-code with smc91111.c driver enabled. I
> am getting this error, because of recent changes in
> gcc-3.4.x series to detect them. 
...
> smc91111.c: In function `smc_phy_configure':
> smc91111.c:1343: error: label at end of compound
...
> 
>       smc_phy_configure_exit:

This is old code. Please use a current version of U-Boot instead. 

> It seems to me that no one there tried the above
> combination. Simple solution is to put some dummy

It seems to me that you didn't bother to check  before  making  bogus
statement.  This  problem was fixed by a patch by Ladislav Michl more
than half a year ago.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When choosing between two evils, I always like to take the  one  I've
never tried before.                     -- Mae West, "Klondike Annie"

[U-Boot-Users] smc91111.c : error: label at end of compound statement

[Komal Shah]

--- Wolfgang Denk <wd@denx.de> wrote:
> 
> > It seems to me that no one there tried the above
> > combination. Simple solution is to put some dummy
> 
> It seems to me that you didn't bother to check 
> before  making  bogus
> statement.  This  problem was fixed by a patch by
> Ladislav Michl more
> than half a year ago.
> 

Ok. Thanx. Now I am taking the latest 1.1.2 release. I
was using u-boot-1.1.1 release. 

=====
---Komal Shah

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 

[U-Boot-Users] Re: smc91111.c : error: label at end of compound statement

[Catalin Marinas]

Komal Shah <komal_shah802003@yahoo.com> writes:
>       smc_phy_configure_exit:
> }
> ----------snip--------------
>
> It seems to me that no one there tried the above
> combination. Simple solution is to put some dummy
> varibale initialisation _or_ is there any compiler
> switch to make it as warning.

It is even simpler to just put a semicolon after this label.

Catalin

[U-Boot-Users] Re: smc91111.c : error: label at end of compound statement

[Wolfgang Denk]

In message <tnxacqv5hlt.fsf@arm.com> you wrote:
> >
> > It seems to me that no one there tried the above
> > combination. Simple solution is to put some dummy
> > varibale initialisation _or_ is there any compiler
> > switch to make it as warning.
> 
> It is even simpler to just put a semicolon after this label.

This is what was added half a year ago.

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Insults are effective only where emotion is present.
	-- Spock, "Who Mourns for Adonais?"  stardate 3468.1