From: Sascha Silbe <t-uboot@infra-silbe.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 02/28] sf: probe: Add new spi_flash_probe support
Date: Sat, 21 Sep 2013 20:51:40 +0200 [thread overview]
Message-ID: <toe38oyj9dv.fsf@twin.sascha.silbe.org> (raw)
In-Reply-To: <02b620d5-cadf-411d-9b7e-5a178149abba@TX2EHSMHS009.ehs.local>
Hi Jagannadha,
Jagannadha Sutradharudu Teki <jagannadha.sutradharudu-teki@xilinx.com>
writes:
> Added new spi_flash_probe support, currently added N25Q*
> flash part attributes support.
[...]
I've given your series another try on Cubox. It looks better this time
(e.g. the probe issue is gone), but there are still a couple of
issues. I'm going to reply to each of the affected patches (2, 7, 14)
individually so it shows up properly in Patchwork.
This patch causes a major regression and thus breaks bisectability. It
rips out support for all SPI flash chips except for STMICRO ones, unless
CONFIG_SPI_FLASH_LEGACY is defined. However, CONFIG_SPI_FLASH_LEGACY
doesn't get defined anywhere.
A better approach would be to make the new code opt-in rather than
opt-out, and selecting it automatically for CONFIG_SPI_FLASH_<vendor> as
support for each vendor is added.
PS: What's the etiquette for the CC list of replies to patches? Keep
all original recipients CC'ed? Or should I have dropped the chip
vendor contacts for this reply?
Sascha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130921/83bc2ee1/attachment.pgp>
next prev parent reply other threads:[~2013-09-21 18:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1379268966-21745-1-git-send-email-jaganna@xilinx.com>
2013-09-15 18:15 ` [U-Boot] [PATCH v3 01/28] sf: Divide spi_flash into multiple parts Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 02/28] sf: probe: Add new spi_flash_probe support Jagannadha Sutradharudu Teki
2013-09-19 6:16 ` Simon Glass
2013-09-19 7:06 ` Jagan Teki
2013-09-19 15:58 ` Simon Glass
2013-09-21 18:51 ` Sascha Silbe [this message]
2013-09-24 10:29 ` Jagan Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 03/28] sf: probe: Add support for M25P* flash parts Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 04/28] sf: probe: Add support for EN25Q* " Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 05/28] sf: probe: Add support for GD25* " Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 06/28] sf: probe: Add support for MX25L* " Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 07/28] sf: probe: Add support for W25* " Jagannadha Sutradharudu Teki
2013-09-21 18:54 ` Sascha Silbe
2013-09-24 6:53 ` Jagan Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 08/28] sf: probe: Add support for S25FL* " Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 09/28] sf: probe: Add support for SST25* " Jagannadha Sutradharudu Teki
2013-09-16 23:00 ` Eric Nelson
2013-09-15 18:15 ` [U-Boot] [PATCH v3 10/28] sf: probe: Add support for AT45DB* " Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 11/28] sf: probe: Give proper spacing on flash table params Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 12/28] sf: probe: Add support for SST_WP Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 13/28] sf: probe: Add support to clear flash BP# bits Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 14/28] sf: probe: Add support for erase sector selection flag Jagannadha Sutradharudu Teki
2013-09-21 18:59 ` Sascha Silbe
2013-09-24 7:00 ` Jagan Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 15/28] sf: probe: Add support for flag status polling Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 16/28] sf: probe: Move BAR config to spi_flash_validate_ids Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 17/28] sf: Add proper comment style on spi_flash structure Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 18/28] sf: ramtron: Add support for separate flash driver Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 19/28] sf: Remove unneeded flash drivers files Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 20/28] sf: probe: Add support for EN25Q64 Jagannadha Sutradharudu Teki
2013-09-15 18:15 ` [U-Boot] [PATCH v3 21/28] sf: probe: Add support for S25FL256S_256K Jagannadha Sutradharudu Teki
2013-09-15 18:16 ` [U-Boot] [PATCH v3 22/28] sf: probe: Add support for S25FL512S_256K Jagannadha Sutradharudu Teki
2013-09-15 18:16 ` [U-Boot] [PATCH v3 23/28] sf: probe: Use print_size arg as page_size Jagannadha Sutradharudu Teki
2013-09-15 18:16 ` [U-Boot] [PATCH v3 24/28] sf: probe: Print erase_size while printing flash details Jagannadha Sutradharudu Teki
2013-09-15 18:16 ` [U-Boot] [PATCH v3 25/28] sf: probe: Simply the BAR configuration logic Jagannadha Sutradharudu Teki
2013-09-15 18:16 ` [U-Boot] [PATCH v3 26/28] sf: ops: Add static qualifier to spi_flash_cmd_bankaddr_write Jagannadha Sutradharudu Teki
2013-09-15 18:16 ` [U-Boot] [PATCH v3 27/28] sf: probe: Add support for MX25L25635F Jagannadha Sutradharudu Teki
2013-09-15 18:16 ` [U-Boot] [PATCH v3 28/28] sf: probe: Add support for MX25L51235F Jagannadha Sutradharudu Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=toe38oyj9dv.fsf@twin.sascha.silbe.org \
--to=t-uboot@infra-silbe.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox