From: "Måns Rullgård" <mans@mansr.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] arm: Switch to -mno-unaligned-access when supported by the compiler
Date: Mon, 10 Feb 2014 15:40:53 +0000 [thread overview]
Message-ID: <yw1xa9dzasca.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <yw1xeh3batjq.fsf@unicorn.mansr.com> ("Måns Rullgård"'s message of "Mon, 10 Feb 2014 15:14:49 +0000")
M?ns Rullg?rd <mans@mansr.com> writes:
> Albert ARIBAUD <albert.u.boot@aribaud.net> writes:
>
>> Hi Tom,
>>
>> On Mon, 10 Feb 2014 08:21:39 -0500, Tom Rini <trini@ti.com> wrote:
>>
>>> On Mon, Feb 10, 2014 at 10:24:47AM +0100, Albert ARIBAUD wrote:
>>> > Hi Tom,
>>> >
>>> > On Tue, 4 Feb 2014 12:05:33 -0500, Tom Rini <trini@ti.com> wrote:
>>> >
>>> > > When we tell the compiler to optimize for ARMv7 it assumes a default of
>>> > > unaligned accesses being supported at the hardware level and can make
>>> > > use of this to perform what it deems as an optimization in any case,
>>> > > including allowing for data to become unaligned. We explicitly disallow
>>> > > this hardware feature so we must tell the compiler.
>>> > >
>>> > > Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
>>> > > Cc: Mans Rullgard <mans@mansr.com>
>>> > > Signed-off-by: Tom Rini <trini@ti.com>
>>> >
>>> > NAK -- the discrepancy between the compiler being told to allow native
>>> > unaligned accesses while at the same time telling the hardware to trap
>>> > them is conscious and voluntary. It was chosen to help detect unaligned
>>> > accesses which are rarely necessary and can be explicitly performed by
>>> > software on a case by case basis.
>>> >
>>> > If and when a specific file requires unaligned access which cannot be
>>> > made by some other mean than enabling -mno-unaligned-access, then this
>>> > file should have it added, not the whole of U-Boot.
>>>
>>> Right, I recall the discussion, and we chose wrong.
>>
>> I am quite prepared to discuss whether we chose wrong or right, and
>> to change my mind when the conditions are right, but I'll need more than
>> such a short and simple statement. :)
>
> I already gave you a detailed explanation some months ago. You refused
> to read it.
For reference: http://article.gmane.org/gmane.comp.boot-loaders.u-boot/171876
--
M?ns Rullg?rd
mans at mansr.com
next prev parent reply other threads:[~2014-02-10 15:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-04 17:05 [U-Boot] [PATCH v2] arm: Switch to -mno-unaligned-access when supported by the compiler Tom Rini
2014-02-04 17:35 ` Måns Rullgård
2014-02-10 9:24 ` Albert ARIBAUD
2014-02-10 13:21 ` Tom Rini
2014-02-10 14:57 ` Albert ARIBAUD
2014-02-10 15:14 ` Måns Rullgård
2014-02-10 15:40 ` Måns Rullgård [this message]
2014-02-10 16:12 ` Albert ARIBAUD
2014-02-10 16:21 ` Måns Rullgård
2014-02-10 16:24 ` Tom Rini
2014-02-10 17:26 ` Albert ARIBAUD
2014-02-10 18:54 ` Wolfgang Denk
2014-02-10 21:26 ` Tom Rini
2014-02-10 22:17 ` Wolfgang Denk
2014-02-10 22:28 ` Tom Rini
2014-02-11 8:19 ` Wolfgang Denk
2014-02-11 12:37 ` Måns Rullgård
2014-02-11 14:43 ` Wolfgang Denk
2014-02-11 15:33 ` Måns Rullgård
2014-02-11 16:37 ` Albert ARIBAUD
2014-02-11 16:44 ` Måns Rullgård
2014-02-11 17:11 ` Albert ARIBAUD
2014-02-11 17:21 ` Albert ARIBAUD
2014-02-12 14:35 ` Tom Rini
2014-02-12 16:19 ` Albert ARIBAUD
2014-02-17 15:45 ` Tom Rini
2014-02-17 15:55 ` Albert ARIBAUD
2014-02-11 18:18 ` Wolfgang Denk
2014-02-11 18:21 ` Måns Rullgård
2014-02-11 8:44 ` Albert ARIBAUD
2014-02-12 14:25 ` Tom Rini
2014-02-12 15:51 ` Wolfgang Denk
2014-02-10 15:21 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xa9dzasca.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox