public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Måns Rullgård" <mans@mansr.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 01/30] Makefile: Rename 'env' target to 'environ'
Date: Fri, 18 Aug 2017 15:31:09 +0100	[thread overview]
Message-ID: <yw1xziax7xsi.fsf@mansr.com> (raw)
In-Reply-To: <20170803182217.149285-2-sjg@chromium.org> (Simon Glass's message of "Thu, 3 Aug 2017 12:21:48 -0600")

Simon Glass <sjg@chromium.org> writes:

> This target stops us using 'env' as a subdirectory. It is not mentioned in
> the help so seems to be an internal target. Rename it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> ---
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 50a002e72f..04a22a6818 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1463,14 +1463,14 @@ checkarmreloc: u-boot
>  		false; \
>  	fi
>
> -env: scripts_basic
> +environ: scripts_basic
>  	$(Q)$(MAKE) $(build)=tools/$@

This broke things:

$ make environ
scripts/Makefile.build:59: tools/environ/Makefile: No such file or directory
make[1]: *** No rule to make target 'tools/environ/Makefile'.  Stop.
make: *** [Makefile:1469: environ] Error 2

The 'env' target was used to build the fw_{print,set}env tools in the
tools/env directory.  The make rule relies on the target having the same
name as the subdirectory.

>  tools-only: scripts_basic $(version_h) $(timestamp_h)
>  	$(Q)$(MAKE) $(build)=tools
>
>  tools-all: export HOST_TOOLS_ALL=y
> -tools-all: env tools ;
> +tools-all: environ tools ;
>
>  cross_tools: export CROSS_BUILD_TOOLS=y
>  cross_tools: tools ;
> -- 
> 2.14.0.rc1.383.gd1ce394fe2-goog
>

-- 
Måns Rullgård

  parent reply	other threads:[~2017-08-18 14:31 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 18:21 [U-Boot] [PATCH v5 00/30] env: Move environment code to use location drivers Simon Glass
2017-08-03 18:21 ` [U-Boot] [PATCH v5 01/30] Makefile: Rename 'env' target to 'environ' Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-18 14:31   ` Måns Rullgård [this message]
2017-08-27 20:09     ` [U-Boot] [PATCH v5 " Simon Glass
2017-08-03 18:21 ` [U-Boot] [PATCH v5 02/30] Move environment files from common/ to env/ Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 03/30] env: Use tabs in ENV_IS_IN_FAT Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot,v5,03/30] " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 04/30] env: common: Make env_get_addr/get_char_memory() static Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 05/30] env: common: Drop env_get_addr() Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot,v5,05/30] " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 06/30] env: common: Factor out the common env_valid check Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 07/30] env: common: Drop env_get_char_init() Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 08/30] env: common: Drop env_get_char_memory() Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 09/30] env: Add an enum for environment state Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 10/30] env: Rename nand env_location to nand_env_location Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 11/30] env: Create a location driver for each location Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:21 ` [U-Boot] [PATCH v5 12/30] env: Convert CONFIG_ENV_IS_IN... to a choice Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 13/30] env: Add a new implementation of environment access Simon Glass
2017-08-16 13:53   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 14/30] env: Switch over to use environment location drivers Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 15/30] env: Drop common init() functions Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot,v5,15/30] " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 16/30] env: Drop the env_name_spec global Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot,v5,16/30] " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 17/30] env: Drop unused env_ptr variables Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot,v5,17/30] " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 18/30] env: Drop env_init_new() Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot,v5,18/30] " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 19/30] env: Drop env_get_char_spec() Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot,v5,19/30] " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 20/30] env: Drop env_relocate_spec() in favour of env_load() Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 21/30] env: Drop saveenv() in favour of env_save() Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 22/30] env: Rename setenv() to env_set() Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot,v5,22/30] " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 23/30] env: Rename common functions related to setenv() Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 24/30] env: Rename eth_setenv_enetaddr() to eth_env_set_enetaddr() Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 25/30] env: Rename getenv/_f() to env_get() Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 26/30] env: Rename getenv_hex(), getenv_yesno(), getenv_ulong() Simon Glass
2017-08-16 13:54   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 27/30] env: Rename eth_getenv_enetaddr() to eth_env_get_enetaddr() Simon Glass
2017-08-16 13:55   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 28/30] env: Rename some other getenv()-related functions Simon Glass
2017-08-16 13:55   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 29/30] env: Adjust the get_char() method to return an int Simon Glass
2017-08-16 13:55   ` [U-Boot] [U-Boot, v5, " Tom Rini
2017-08-03 18:22 ` [U-Boot] [PATCH v5 30/30] env: Adjust the load() method to return an error Simon Glass
2017-08-16 13:55   ` [U-Boot] [U-Boot, v5, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yw1xziax7xsi.fsf@mansr.com \
    --to=mans@mansr.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox