From: mita@miraclelinux.com (Akinobu Mita)
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: 'Geert Uytterhoeven' <geert@linux-m68k.org>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org, linux-m68k@vger.kernel.org,
parisc-linux@parisc-linux.org,
Linux/PPC Development <linuxppc-dev@ozlabs.org>,
linux390@de.ibm.com, linuxsh-dev@lists.sourceforge.net,
sparclinux@vger.kernel.org, ultralinux@vger.kernel.org,
Andi Kleen <ak@suse.de>
Subject: Re: [PATCH 5/6] fix warning on test_ti_thread_flag()
Date: Thu, 26 Jan 2006 03:50:04 +0000 [thread overview]
Message-ID: <20060126035004.GA11543@miraclelinux.com> (raw)
In-Reply-To: <200601252002.k0PK2Mg31276@unix-os.sc.intel.com>
On Wed, Jan 25, 2006 at 12:02:21PM -0800, Chen, Kenneth W wrote:
> Geert Uytterhoeven wrote on Wednesday, January 25, 2006 9:19 AM
> > > I don't think you need to change the flags size.
> >
> > Passing a pointer to a 32-bit entity to a function that takes a
> > pointer to a 64-bit entity is a classical endianness bug. So it's
> > better to change it, before people copy the code to a big endian
> > platform.
>
> Well, x86-64 and linux-ia64 both use little endian. I don't
> understand why you are barking at us with big endian issue.
>
I can fix this without changing the flags size for those architectures.
1. Introduce *_le_bit() bit operations which takes void *addr
(already I have these functions in the scope of
HAVE_ARCH_EXT2_NON_ATOMIC_BITOPS in my patch)
2. Change flags to __u8 flags[4] or __u8 flags[8] for each architectures.
3. Use *_le_bit() in include/linux/thread_info.h
next prev parent reply other threads:[~2006-01-26 3:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 11:26 [PATCH 0/6] RFC: use include/asm-generic/bitops.h Akinobu Mita
2006-01-25 11:28 ` [PATCH 1/6] {set,clear,test}_bit() related cleanup Akinobu Mita
2006-01-26 16:14 ` Pavel Machek
2006-01-26 16:47 ` Russell King
2006-01-26 19:14 ` Paul Jackson
2006-01-25 11:30 ` [PATCH 2/6] use non atomic operations for minix_*_bit() and ext2_*_bit() Akinobu Mita
2006-01-25 11:32 ` [PATCH 3/6] C-language equivalents of include/asm-*/bitops.h Akinobu Mita
2006-01-25 11:54 ` Keith Owens
2006-01-26 2:13 ` Akinobu Mita
2006-01-25 20:02 ` Russell King
2006-01-25 23:25 ` Ian Molton
2006-01-26 0:06 ` Richard Henderson
2006-01-26 4:34 ` Edgar Toernig
2006-01-26 17:30 ` Richard Henderson
2006-01-26 8:55 ` Russell King
2006-01-26 16:18 ` [parisc-linux] " Grant Grundler
2006-01-26 16:30 ` [parisc-linux] Re: [PATCH 3/6] C-language equivalents of Nicolas Pitre
2006-01-27 0:28 ` John David Anglin
2006-01-26 16:40 ` [parisc-linux] Re: [PATCH 3/6] C-language equivalents of include/asm-*/bitops.h Russell King
2006-01-26 22:55 ` Grant Grundler
2006-01-26 23:03 ` Russell King
2006-01-29 7:12 ` Stuart Brady
2006-01-30 4:03 ` [parisc-linux] Re: [PATCH 3/6] C-language equivalents of David S. Miller
2006-01-30 17:06 ` [parisc-linux] Re: [PATCH 3/6] C-language equivalents of include/asm-*/bitops.h Ralf Baechle
2006-01-30 19:50 ` Stuart Brady
2006-01-30 23:02 ` [parisc-linux] Re: [PATCH 3/6] C-language equivalents of David S. Miller
2006-01-27 12:51 ` [PATCH 3/6] C-language equivalents of include/asm-*/bitops.h Hirokazu Takata
2006-01-30 3:29 ` Akinobu Mita
2006-01-25 11:34 ` [PATCH 5/6] fix warning on test_ti_thread_flag() Akinobu Mita
2006-01-25 12:28 ` Geert Uytterhoeven
2006-01-25 17:08 ` Chen, Kenneth W
2006-01-25 17:19 ` Geert Uytterhoeven
2006-01-25 20:02 ` Chen, Kenneth W
2006-01-26 3:50 ` Akinobu Mita [this message]
2006-01-26 4:12 ` Paul Mackerras
2006-01-25 22:28 ` Paul Mackerras
2006-01-26 0:04 ` David S. Miller
2006-01-25 11:35 ` [PATCH 6/6] remove unused generic bitops in include/linux/bitops.h Akinobu Mita
[not found] ` <20060125113336.GE18584@miraclelinux.com>
2006-01-26 1:49 ` [PATCH 4/6] use include/asm-generic/bitops for each architecture Akinobu Mita
2006-01-27 13:04 ` [PATCH 4/6] use include/asm-generic/bitops for each Hirokazu Takata
2006-01-30 3:15 ` [PATCH 4/6] use include/asm-generic/bitops for each architecture Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060126035004.GA11543@miraclelinux.com \
--to=mita@miraclelinux.com \
--cc=ak@suse.de \
--cc=geert@linux-m68k.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxsh-dev@lists.sourceforge.net \
--cc=parisc-linux@parisc-linux.org \
--cc=sparclinux@vger.kernel.org \
--cc=ultralinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox