From mboxrd@z Thu Jan 1 00:00:00 1970 From: mita@miraclelinux.com (Akinobu Mita) Date: Tue, 07 Feb 2006 02:02:16 +0000 Subject: Re: [patch 11/44] generic find_{next,first}{,_zero}_bit() Message-Id: <20060207020216.GA9323@miraclelinux.com> List-Id: References: <20060201090324.373982000@localhost.localdomain> <20060201090224.536581000@localhost.localdomain> <12367.1139221560@warthog.cambridge.redhat.com> In-Reply-To: <12367.1139221560@warthog.cambridge.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Howells Cc: linux-kernel@vger.kernel.org, Richard Henderson , Ivan Kokshaysky , dev-etrax@axis.com, Yoshinori Sato , linux-ia64@vger.kernel.org, Hirokazu Takata , Greg Ungerer , linux-mips@linux-mips.org, parisc-linux@parisc-linux.org, linuxsh-dev@lists.sourceforge.net, linuxsh-shmedia-dev@lists.sourceforge.net, sparclinux@vger.kernel.org, ultralinux@vger.kernel.org, Miles Bader , Chris Zankel On Mon, Feb 06, 2006 at 10:26:00AM +0000, David Howells wrote: > Akinobu Mita wrote: > > > This patch introduces the C-language equivalents of the functions below: > > > > unsigned logn find_next_bit(const unsigned long *addr, unsigned long size, > > unsigned long offset); > > unsigned long find_next_zero_bit(const unsigned long *addr, unsigned long size, > > unsigned long offset); > > unsigned long find_first_zero_bit(const unsigned long *addr, > > unsigned long size); > > unsigned long find_first_bit(const unsigned long *addr, unsigned long size); > > These big functions should perhaps be out of line. Yes. I'll make them and below out of line. - hweight*() - ext2_find_*_zero_bit() - minix_find_first_zero_bit()