Re: [RFC/PATCH] envctrl framework and envctrltwo (UE250) driver

[Eric Brower <ebrower@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

I'm hesitant to provide a patch to a patch, but there was a tiny
buglet in how the Thermal Error LED was represented in sysfs.  A
patchlet is attached, but I can resend an entire new patch if
necessary.  There are probably a few others lurking in there... :)

E


On Tue, 22 Feb 2005 19:46:02 -0800, David S. Miller <davem@davemloft.net> wrote:
> On Tue, 22 Feb 2005 14:27:58 -0800
> Eric Brower <ebrower@gmail.com> wrote:
> 
> > DaveM, et. al,
> >
> > It occurred to me that we had spoken a long while back about
> > coalescing the logic for system LED blinking into one location (one
> > timer, I suppose).  This driver does not do that, but we could speak
> > about how you'd like that done were this driver at some point
> > considered for inclusion in the kernel.
> 
> Don't worry about it for the time being.
> 
> I'll review your envctrl stuff soon, it looks really nice.
> 


-- 
E

[-- Attachment #2: 26_envctrl_templed.patch --]
[-- Type: application/octet-stream, Size: 810 bytes --]

--- arch/sparc64/kernel/env_envctrltwo.c.old	2005-02-23 19:12:10.552473226 -0800
+++ arch/sparc64/kernel/env_envctrltwo.c	2005-02-23 19:12:28.074809426 -0800
@@ -46,7 +46,7 @@
 #include "env_lib.h"
 
 #define ENV2_DEVNAME	"envctrltwo"
-#define ENV2_VERSION    "0.2.0"
+#define ENV2_VERSION    "0.3.0"
 
 #define ENV2_DEBUG_THERMS (0) /* dump thermisters found and values probed  */
 #define ENV2_DEBUG_FAN    (0) /* user fanspeed control via sysfs - DANGER! */
@@ -676,7 +676,7 @@
 	ret += sprintf(buf + ret, "DISK ERROR: [%s]\n", 
 		stat & ENV2_LED_DISKERR ? "OFF" : "ON");
 	ret += sprintf(buf + ret, "TEMP ERROR: [%s]\n", 
-		stat & ENV2_LED_DISKERR ? "OFF" : "ON");
+		stat & ENV2_LED_TEMPERR ? "OFF" : "ON");
 	ret += sprintf(buf + ret, "PS ERROR:   [%s]\n", 
 		stat & ENV2_LED_PSERR ? "OFF" : "ON");