From: Dave Reisner <d@falconindy.com>
To: util-linux@vger.kernel.org
Cc: Dave Reisner <dreisner@archlinux.org>
Subject: [PATCH 2/2] mountpoint: support symbolic and relative paths
Date: Sun, 9 Oct 2011 11:12:05 -0400 [thread overview]
Message-ID: <1318173125-16156-2-git-send-email-dreisner@archlinux.org> (raw)
In-Reply-To: <1318173125-16156-1-git-send-email-dreisner@archlinux.org>
Use our own canonicalize library to resolve a provided path before
checking if its a mountpoint.
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
---
Unless I've missed something, this should bring u-l's mountpoint to feature
parity with sysvinit's.
sys-utils/Makefile.am | 1 +
sys-utils/mountpoint.c | 5 ++++-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/sys-utils/Makefile.am b/sys-utils/Makefile.am
index 8059ee6..34108da 100644
--- a/sys-utils/Makefile.am
+++ b/sys-utils/Makefile.am
@@ -44,6 +44,7 @@ flock_SOURCES = flock.c $(top_srcdir)/lib/strutils.c
if BUILD_MOUNTPOINT
bin_PROGRAMS += mountpoint
+mountpoint_SOURCES = mountpoint.c $(top_srcdir)/lib/canonicalize.c
mountpoint_LDADD = $(ul_libmount_la)
mountpoint_CFLAGS = $(AM_CFLAGS) -I$(ul_libmount_incdir)
dist_man_MANS += mountpoint.1
diff --git a/sys-utils/mountpoint.c b/sys-utils/mountpoint.c
index e021c70..204f061 100644
--- a/sys-utils/mountpoint.c
+++ b/sys-utils/mountpoint.c
@@ -37,6 +37,7 @@
#include "nls.h"
#include "xalloc.h"
#include "c.h"
+#include "canonicalize.h"
static int quiet;
@@ -147,7 +148,8 @@ int main(int argc, char **argv)
if (optind + 1 != argc)
usage(stderr);
- spec = argv[optind++];
+ /* resolve relative paths to absolute */
+ spec = canonicalize_path(argv[optind++]);
if (stat(spec, &st)) {
if (!quiet)
@@ -179,5 +181,6 @@ int main(int argc, char **argv)
}
finish:
+ free(spec);
return rc;
}
--
1.7.7
next prev parent reply other threads:[~2011-10-09 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-09 15:12 [PATCH 1/2] mountpoint: refactor exit path Dave Reisner
2011-10-09 15:12 ` Dave Reisner [this message]
2011-10-10 19:45 ` Dave Reisner
2011-10-10 23:05 ` Karel Zak
-- strict thread matches above, loose matches on Subject: below --
2011-10-10 23:14 Dave Reisner
2011-10-10 23:14 ` [PATCH 2/2] mountpoint: support symbolic and relative paths Dave Reisner
2011-10-11 9:34 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318173125-16156-2-git-send-email-dreisner@archlinux.org \
--to=d@falconindy.com \
--cc=dreisner@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).