From: Davidlohr Bueso <dave@gnu.org>
To: Maurizio Lombardi <m.lombardi85@gmail.com>
Cc: util-linux@vger.kernel.org
Subject: Re: mkfs.minix V3 is broken
Date: Mon, 21 Nov 2011 23:06:15 +0100 [thread overview]
Message-ID: <1321913175.3253.8.camel@offbook> (raw)
In-Reply-To: <CAMtsiiDWF3xCiFtENTaYS36zKOJjRHML0x2nk1P0d0zeU3qi0A@mail.gmail.com>
On Mon, 2011-11-21 at 20:40 +0100, Maurizio Lombardi wrote:
> Hi all,
>
> I noticed a lot of bugs in the mkfs.minix program when dealing with V3
> filesystems.
> I did a lot of fixes in the source code and then I decided to set up a
> github repository to make the review easier:
>
> git@github.com:maurizio-lombardi/util-linux.git
>
> Can the mkfs.minix mantainer review the patches please?
Most of the work I did on supporting v3 was based on the kernel's
implementation and the mkfs shipped with minix (by ast), so a lot of
what you say makes sense. I've taken a quick look at the changes and
most are bugs are pretty straightforward, except:
- mkfs.minix: The total number of zones is limited to 65536 only on V1
filesystems
Unless I'm missing something, this doesn't really change any logic.
I'll give the changes a proper test over the weekend.
Thanks,
Davidlohr
>
> Please cc me because I'm not subscribed to the list.
>
> Regards,
next prev parent reply other threads:[~2011-11-21 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 19:40 mkfs.minix V3 is broken Maurizio Lombardi
2011-11-21 22:06 ` Davidlohr Bueso [this message]
2011-11-22 9:03 ` Maurizio Lombardi
2011-11-22 10:05 ` Maurizio Lombardi
2011-11-22 10:54 ` Karel Zak
2011-11-27 22:03 ` Davidlohr Bueso
2011-11-28 9:27 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321913175.3253.8.camel@offbook \
--to=dave@gnu.org \
--cc=m.lombardi85@gmail.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).