[PATCH 4/4] partx: don't treat empty partition table as error

[PATCH 4/4] partx: don't treat empty partition table as error

[Phillip Susi]

If a partition table was detected, but it had no partitions
in it, a poorly worded error message was printed and further
action halted.  For partx -a, this gave an unnecessary error
and for partx -u, prevented update from removing all partitions.

Signed-off-by: Phillip Susi <psusi@cfl.rr.com>
---
 partx/partx.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/partx/partx.c b/partx/partx.c
index 50b0c20..f4f2db1 100644
--- a/partx/partx.c
+++ b/partx/partx.c
@@ -696,12 +696,6 @@ static blkid_partlist get_partlist(blkid_probe pr,
 		printf(_("%s: partition table type '%s' detected\n"),
 		       device, blkid_parttable_get_type(tab));
 
-	if (!blkid_partlist_numof_partitions(ls)) {
-		warnx(_("%s: %s partition table does not contains "
-			"usable partitions"), device,
-			blkid_parttable_get_type(tab));
-		return NULL;
-	}
 	return ls;
 }
 
-- 
1.7.5.4

Re: [PATCH 4/4] partx: don't treat empty partition table as error

[Karel Zak]

On Mon, Dec 05, 2011 at 03:02:52PM -0500, Phillip Susi wrote:
> -	if (!blkid_partlist_numof_partitions(ls)) {
> -		warnx(_("%s: %s partition table does not contains "
> -			"usable partitions"), device,
> -			blkid_parttable_get_type(tab));
> -		return NULL;
> -	}

 I have replaced the warnign and return NULL with message printed in
 verbose mode only.

 Thanks!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com