From: Davidlohr Bueso <dave@gnu.org>
To: "Voelker, Bernhard" <bernhard.voelker@siemens-enterprise.com>
Cc: Karel Zak <kzak@redhat.com>, util-linux <util-linux@vger.kernel.org>
Subject: RE: [PATCH] prlimit: return proper type
Date: Fri, 09 Dec 2011 14:13:10 +0100 [thread overview]
Message-ID: <1323436390.2522.0.camel@offbook> (raw)
In-Reply-To: <7856072A9D04C24B82DFE2B1112FE38A0D87014694@MCHP058A.global-ad.net>
I'd rather have the function return a proper status and not use it than
not return anything.
Thanks,
Davidlohr
On Fri, 2011-12-09 at 10:48 +0100, Voelker, Bernhard wrote:
> Davidlohr Bueso wrote:
>
> > The add_prlim() function's definition currently returns a bogus structure.
>
> > -static struct prlimit *add_prlim(char *ops, struct list_head *lims, size_t id)
> > +static int add_prlim(char *ops, struct list_head *lims, size_t id)
>
> Why not void and remove that return stmt?
> The return code is not used anywhere.
>
> Have a nice day,
> Berny
next prev parent reply other threads:[~2011-12-09 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 20:19 [PATCH] prlimit: return proper type Davidlohr Bueso
2011-12-09 9:48 ` Voelker, Bernhard
2011-12-09 13:13 ` Davidlohr Bueso [this message]
2011-12-16 10:31 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323436390.2522.0.camel@offbook \
--to=dave@gnu.org \
--cc=bernhard.voelker@siemens-enterprise.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).