From: Dave Reisner <d@falconindy.com>
To: util-linux@vger.kernel.org
Cc: Dave Reisner <dreisner@archlinux.org>
Subject: [PATCH 1/2] findmnt: use warnx for libmnt error callback
Date: Sun, 11 Dec 2011 13:58:04 -0500 [thread overview]
Message-ID: <1323629885-17940-2-git-send-email-dreisner@archlinux.org> (raw)
In-Reply-To: <1323629885-17940-1-git-send-email-dreisner@archlinux.org>
libmount doesn't set errno appropriately here:
$ findmnt -s
findmnt: /etc/fstab: parse error at line 20: Success
Signed-off-by: Dave Reisner <dreisner@archlinux.org>
---
misc-utils/findmnt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/misc-utils/findmnt.c b/misc-utils/findmnt.c
index 9c2b9fc..4577dc6 100644
--- a/misc-utils/findmnt.c
+++ b/misc-utils/findmnt.c
@@ -484,7 +484,7 @@ leave:
static int parser_errcb(struct libmnt_table *tb __attribute__ ((__unused__)),
const char *filename, int line)
{
- warn(_("%s: parse error at line %d"), filename, line);
+ warnx(_("%s: parse error at line %d"), filename, line);
return 0;
}
--
1.7.8
next prev parent reply other threads:[~2011-12-11 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 18:58 [PATCH 0/2] Add user-defined fstab location for findmnt Dave Reisner
2011-12-11 18:58 ` Dave Reisner [this message]
2011-12-16 10:43 ` [PATCH 1/2] findmnt: use warnx for libmnt error callback Karel Zak
2011-12-11 18:58 ` [PATCH 2/2] findmnt: support alternative location of fstab Dave Reisner
2011-12-16 10:48 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323629885-17940-2-git-send-email-dreisner@archlinux.org \
--to=d@falconindy.com \
--cc=dreisner@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).