From: Davidlohr Bueso <dave@gnu.org>
To: Dave Reisner <d@falconindy.com>
Cc: util-linux@vger.kernel.org, Dave Reisner <dreisner@archlinux.org>
Subject: Re: [PATCH 1/3] column: use xalloc libs
Date: Tue, 20 Dec 2011 15:13:36 +0100 [thread overview]
Message-ID: <1324390416.3316.13.camel@offbook> (raw)
In-Reply-To: <1324388164-2112-1-git-send-email-dreisner@archlinux.org>
On Tue, 2011-12-20 at 08:36 -0500, Dave Reisner wrote:
> Signed-off-by: Dave Reisner <dreisner@archlinux.org>
> ---
> text-utils/column.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/text-utils/column.c b/text-utils/column.c
> index 79d2842..c642680 100644
> --- a/text-utils/column.c
> +++ b/text-utils/column.c
> @@ -395,7 +395,7 @@ static wchar_t *mbs_to_wcs(const char *s)
> n = mbstowcs((wchar_t *)0, s, 0);
> if (n < 0)
> return NULL;
> - wcs = malloc((n + 1) * sizeof(wchar_t));
> + wcs = xmalloc((n + 1) * sizeof(wchar_t));
> if (!wcs)
> return NULL;
Hmm this isn't that straight forward, if the memory allocation fails
here we don't necessarily abort the program.
> n = mbstowcs(wcs, s, n + 1);
next prev parent reply other threads:[~2011-12-20 14:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 13:36 [PATCH 1/3] column: use xalloc libs Dave Reisner
2011-12-20 13:36 ` [PATCH 2/3] lscpu: " Dave Reisner
2012-01-04 13:37 ` Karel Zak
2011-12-20 13:36 ` [PATCH 3/3] tools/checkxalloc.sh: add new code checking script Dave Reisner
2012-01-04 13:39 ` Karel Zak
2011-12-20 14:13 ` Davidlohr Bueso [this message]
2012-01-04 13:37 ` [PATCH 1/3] column: use xalloc libs Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324390416.3316.13.camel@offbook \
--to=dave@gnu.org \
--cc=d@falconindy.com \
--cc=dreisner@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).