RE: [PATCH v3 3/4] lslocks: new command

[Davidlohr Bueso <dave@gnu.org>]

On Mon, 2012-02-27 at 18:16 +0100, Voelker, Bernhard wrote:
> Davidlohr Bueso wrote:
> 
> 
> > +static char *get_cmdname(pid_t pid)
> > +{
> > +	FILE *fp;
> > +	char path[PATH_MAX];
> > +
> > +	sprintf(path, "/proc/%d/comm", pid);
> > +	if (!(fp = fopen(path, "r")))
> > +		return NULL;
> > +
> > +	/* just need the first line */
> > +	if (!fgets(path, sizeof(path), fp))
> > +		goto out;
> > +out:
> 
> this looks strange to me:
> if fgets fails, then we want to ...
> 
> > +	fclose(fp);
> 
> ... but certainly not this:

yep, that's bogus. Will send a v4.

Thanks.

> 
> > +	path[strlen(path) - 1] = '\0';
> > +	return xstrdup(path);
> > +}
> 
> Have a nice day,
> Berny
>