public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: kerolasa@iki.fi
Subject: [PATCH 03/17] sfdisk: use rpmatch to yes/no question
Date: Mon,  5 Mar 2012 20:38:40 +0100	[thread overview]
Message-ID: <1330976334-10751-4-git-send-email-kerolasa@iki.fi> (raw)
In-Reply-To: <1330976334-10751-1-git-send-email-kerolasa@iki.fi>

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
 fdisk/sfdisk.c |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/fdisk/sfdisk.c b/fdisk/sfdisk.c
index 6267652..f549c64 100644
--- a/fdisk/sfdisk.c
+++ b/fdisk/sfdisk.c
@@ -53,6 +53,7 @@
 #include "gpt.h"
 #include "pathnames.h"
 #include "canonicalize.h"
+#include "rpmatch.h"
 
 /*
  * Table of contents:
@@ -3140,7 +3141,7 @@ do_reread(char *dev) {
 static void
 do_fdisk(char *dev) {
     int fd;
-    int c, answer;
+    char answer[32];
     struct stat statbuf;
     int interactive = isatty(0);
     struct disk_desc *z;
@@ -3197,22 +3198,20 @@ do_fdisk(char *dev) {
 	    else
 		warnx(_("I don't like this - probably you should answer No\n"));
 	}
- ask:
 	if (interactive) {
+ ask:
 	    if (no_write)
+		/* TRANSLATORS: sfdisk uses rpmatch which means the answers y and n
+		 * should be translated, but that is not the case with q answer. */
 		printf(_("Are you satisfied with this? [ynq] "));
 	    else
 		printf(_("Do you want to write this to disk? [ynq] "));
-	    answer = c = getchar();
-	    while (c != '\n' && c != EOF)
-		c = getchar();
-	    if (c == EOF)
-		printf(_("\nsfdisk: premature end of input\n"));
-	    if (c == EOF || answer == 'q' || answer == 'Q') {
+	    fgets(answer, sizeof(answer), stdin);
+	    if (answer[0] == 'q' || answer[0] == 'Q') {
 		errx(EXIT_FAILURE, _("Quitting - nothing changed"));
-	    } else if (answer == 'n' || answer == 'N') {
+	    } else if (rpmatch(answer) == 1) {
 		continue;
-	    } else if (answer == 'y' || answer == 'Y') {
+	    } else if (rpmatch(answer) == 0) {
 		break;
 	    } else {
 		printf(_("Please answer one of y,n,q\n"));
-- 
1.7.9.2


  parent reply	other threads:[~2012-03-05 19:39 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-04 13:35 [pull] fixes to todo items etc Sami Kerola
2012-03-05 12:38 ` Karel Zak
2012-03-05 19:38   ` Sami Kerola
2012-03-05 19:38     ` [PATCH 01/17] docs: add deprecation comments Sami Kerola
2012-03-05 19:38     ` [PATCH 02/17] docs: TODO removal, login-utils error printing Sami Kerola
2012-03-05 19:38     ` Sami Kerola [this message]
2012-03-05 19:38     ` [PATCH 04/17] mesg: use rpmatch to yes/no question Sami Kerola
2012-03-05 19:38     ` [PATCH 05/17] vipw: " Sami Kerola
2012-03-05 19:38     ` [PATCH 06/17] docs: TODO removal, rpmatch task is done Sami Kerola
2012-03-05 19:38     ` [PATCH 07/17] chfn: use pathnames.h for paths Sami Kerola
2012-03-05 19:38     ` [PATCH 08/17] chsh: " Sami Kerola
2012-03-05 19:38     ` [PATCH 09/17] lib: add fileutils function collection Sami Kerola
     [not found]       ` <"1330984305.2953.25.camel"@offbook>
     [not found]       ` <"1 330984305.2953.25.camel"@offbook>
2012-03-05 21:51       ` Davidlohr Bueso
2012-03-09  7:56         ` Sami Kerola
2012-03-09 11:48           ` Davidlohr Bueso
2012-03-09 12:20             ` Karel Zak
2012-03-10 11:49               ` Sami Kerola
2012-03-05 19:38     ` [PATCH 10/17] wall: use xmkstemp for temporary file Sami Kerola
2012-03-05 19:38     ` [PATCH 11/17] setpwnam: use xmkstemp() and lckpwdf() Sami Kerola
2012-03-05 19:38     ` [PATCH 12/17] vipw: " Sami Kerola
2012-03-05 19:38     ` [PATCH 13/17] pathnames: clean up various user database paths Sami Kerola
2012-03-05 20:44       ` Sami Kerola
2012-03-05 19:38     ` [PATCH 14/17] docs: TODO removal, ldattach usage is done Sami Kerola
2012-03-05 19:38     ` [PATCH 15/17] include: add asprintf wrapper Sami Kerola
2012-03-05 19:52       ` Dave Reisner
2012-03-05 20:47         ` Sami Kerola
2012-03-05 19:38     ` [PATCH 16/17] xalloc: use xasprintf in all files Sami Kerola
2012-03-05 19:38     ` [PATCH 17/17] build-sys: fix chkdupexe regression Sami Kerola
2012-03-20  8:07 ` [pull] fixes to todo items etc Karel Zak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1330976334-10751-4-git-send-email-kerolasa@iki.fi \
    --to=kerolasa@iki.fi \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox