util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* lnussel/su-v1: Portability patch for GNU/Hurd
       [not found] <87zk8wboif.fsf@schwinge.name>
@ 2012-05-25 18:40 ` Thomas Schwinge
  2012-05-25 18:40   ` [PATCH 1/3] su: Don't include the unused <sys/fsuid.h> Thomas Schwinge
                     ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Thomas Schwinge @ 2012-05-25 18:40 UTC (permalink / raw)
  To: util-linux, ludwig.nussel

Hi!

Only the first (and tiny) patch is needed for portability; the other two
are just general clean-up.

Then, su appears to work -- based on a bit of manual testing that I have
just done.


Grüße,
 Thomas

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/3] su: Don't include the unused <sys/fsuid.h>.
  2012-05-25 18:40 ` lnussel/su-v1: Portability patch for GNU/Hurd Thomas Schwinge
@ 2012-05-25 18:40   ` Thomas Schwinge
  2012-05-25 18:41   ` [PATCH 2/3] su: Add AM_LDFLAGS to su_LDFLAGS Thomas Schwinge
  2012-05-25 18:41   ` [PATCH 3/3] su: Mention SUID_* feature Thomas Schwinge
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Schwinge @ 2012-05-25 18:40 UTC (permalink / raw)
  To: util-linux, ludwig.nussel; +Cc: Thomas Schwinge

Signed-off-by: Thomas Schwinge <thomas@codesourcery.com>
---
 login-utils/su.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/login-utils/su.c b/login-utils/su.c
index edd6d10..29042f0 100644
--- a/login-utils/su.c
+++ b/login-utils/su.c
@@ -81,7 +81,6 @@ enum
 # include <security/pam_misc.h>
 # include <signal.h>
 # include <sys/wait.h>
-# include <sys/fsuid.h>
 #endif
 
 #if HAVE_SYSLOG_H && HAVE_SYSLOG
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] su: Add AM_LDFLAGS to su_LDFLAGS.
  2012-05-25 18:40 ` lnussel/su-v1: Portability patch for GNU/Hurd Thomas Schwinge
  2012-05-25 18:40   ` [PATCH 1/3] su: Don't include the unused <sys/fsuid.h> Thomas Schwinge
@ 2012-05-25 18:41   ` Thomas Schwinge
  2012-05-25 18:41   ` [PATCH 3/3] su: Mention SUID_* feature Thomas Schwinge
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Schwinge @ 2012-05-25 18:41 UTC (permalink / raw)
  To: util-linux, ludwig.nussel; +Cc: Thomas Schwinge

Signed-off-by: Thomas Schwinge <thomas@codesourcery.com>
---
 login-utils/Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/login-utils/Makefile.am b/login-utils/Makefile.am
index 60e6f10..d376234 100644
--- a/login-utils/Makefile.am
+++ b/login-utils/Makefile.am
@@ -89,7 +89,7 @@ su_CFLAGS = -DUSE_PAM=1 $(SUID_CFLAGS) $(AM_CFLAGS)
 chfn_LDFLAGS = $(SUID_LDFLAGS) $(AM_LDFLAGS)
 chsh_LDFLAGS = $(SUID_LDFLAGS) $(AM_LDFLAGS)
 newgrp_LDFLAGS = $(SUID_LDFLAGS) $(AM_LDFLAGS)
-su_LDFLAGS = $(SUID_LDFLAGS)
+su_LDFLAGS = $(SUID_LDFLAGS) $(AM_LDFLAGS)
 
 login_ldadd_common += -lpam -lpam_misc
 
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] su: Mention SUID_* feature.
  2012-05-25 18:40 ` lnussel/su-v1: Portability patch for GNU/Hurd Thomas Schwinge
  2012-05-25 18:40   ` [PATCH 1/3] su: Don't include the unused <sys/fsuid.h> Thomas Schwinge
  2012-05-25 18:41   ` [PATCH 2/3] su: Add AM_LDFLAGS to su_LDFLAGS Thomas Schwinge
@ 2012-05-25 18:41   ` Thomas Schwinge
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Schwinge @ 2012-05-25 18:41 UTC (permalink / raw)
  To: util-linux, ludwig.nussel; +Cc: Thomas Schwinge

Signed-off-by: Thomas Schwinge <thomas@codesourcery.com>
---
 Documentation/howto-compilation.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/howto-compilation.txt b/Documentation/howto-compilation.txt
index 3617b34..bebe0d2 100644
--- a/Documentation/howto-compilation.txt
+++ b/Documentation/howto-compilation.txt
@@ -25,7 +25,7 @@ Compiling
 	./configure SUID_CFLAGS="-fpie" SUID_LDFLAGS="-pie"
 
 	The SUID_* feature is currently supported for chfn, chsh,
-	newgrp, write, mount, and umount.
+	newgrp, su, write, mount, and umount.
 
 	Preferred compilation options for developers, when
 	using gcc, are:
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-05-25 18:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <87zk8wboif.fsf@schwinge.name>
2012-05-25 18:40 ` lnussel/su-v1: Portability patch for GNU/Hurd Thomas Schwinge
2012-05-25 18:40   ` [PATCH 1/3] su: Don't include the unused <sys/fsuid.h> Thomas Schwinge
2012-05-25 18:41   ` [PATCH 2/3] su: Add AM_LDFLAGS to su_LDFLAGS Thomas Schwinge
2012-05-25 18:41   ` [PATCH 3/3] su: Mention SUID_* feature Thomas Schwinge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).