util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@gnu.org>
To: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>,
	"Karel Zak" <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] allow to create a minix3fs with a blocksize != 1K
Date: Sun, 10 Jun 2012 21:58:38 +0200	[thread overview]
Message-ID: <1339358318.3369.35.camel@offbook> (raw)
In-Reply-To: <4FAAE7FB.2060808@gmail.com>

On Wed, 2012-05-09 at 23:56 +0200, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> Have used it to test minixfs support with various block sizes.
> 

Hi Vladimir,

A few comments:

+       if (MINIX_BLOCK_SIZE % 512 || MINIX_BLOCK_SIZE < 1024
+           || MINIX_BLOCK_SIZE >= 65536)
+               usage();

This check should be part of the switch statement, perhaps in its own
function.
+       if (*tmp && ...)


+       if (fs_version != 3 && MINIX_BLOCK_SIZE != MINIX12_BLOCK_SIZE)
+               usage();

We should set -1/-2 options to be mutually exclusive with -B.

+#define MAX_MINIX_BLOCK_SIZE 65536
Isn't the max minix block size 4096?

+#define MINIX12_BLOCK_SIZE   1024
This is the minimal block size, including v3. MINIX12_ doesn't describe
it well.


Also, please send the patches in the body of the message - just as with
the lkml.

Thanks,
Davidlohr


  parent reply	other threads:[~2012-06-10 19:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4FAAE6EA.3080308@gmail.com>
2012-05-09 21:56 ` [PATCH] allow to create a minix3fs with a blocksize != 1K Vladimir 'φ-coder/phcoder' Serbinenko
2012-05-15  9:05   ` Karel Zak
2012-06-10 19:58   ` Davidlohr Bueso [this message]
2012-06-10 20:21     ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-06-11 11:45       ` Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339358318.3369.35.camel@offbook \
    --to=dave@gnu.org \
    --cc=kzak@redhat.com \
    --cc=phcoder@gmail.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).