From: Milan Broz <mbroz@redhat.com>
To: util-linux@vger.kernel.org
Cc: Milan Broz <mbroz@redhat.com>
Subject: [PATCH 2/5] lsblk: support -o +<attr> for adding attribute to output fields.
Date: Thu, 26 Jul 2012 15:52:05 +0200 [thread overview]
Message-ID: <1343310728-16624-2-git-send-email-mbroz@redhat.com> (raw)
In-Reply-To: <1343310728-16624-1-git-send-email-mbroz@redhat.com>
Signed-off-by: Milan Broz <mbroz@redhat.com>
---
misc-utils/lsblk.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/misc-utils/lsblk.c b/misc-utils/lsblk.c
index cb2b768..19c8edd 100644
--- a/misc-utils/lsblk.c
+++ b/misc-utils/lsblk.c
@@ -1213,6 +1213,7 @@ int main(int argc, char *argv[])
struct lsblk _ls;
int tt_flags = TT_FL_TREE;
int i, c, status = EXIT_FAILURE;
+ char *outarg = NULL;
enum {
EXCL_NONE,
@@ -1290,11 +1291,7 @@ int main(int argc, char *argv[])
tt_flags |= TT_FL_NOHEADINGS;
break;
case 'o':
- ncolumns = string_to_idarray(optarg,
- columns, ARRAY_SIZE(columns),
- column_name_to_id);
- if (ncolumns < 0)
- return EXIT_FAILURE;
+ outarg = optarg;
break;
case 'P':
exclusive_option(&excl_rlP, EXCL_PAIRS, "--{raw,list,pairs}");
@@ -1363,6 +1360,10 @@ int main(int argc, char *argv[])
columns[ncolumns++] = COL_TARGET;
}
+ if (outarg && string_add_to_idarray(outarg, columns, ARRAY_SIZE(columns),
+ &ncolumns, column_name_to_id) < 0)
+ return EXIT_FAILURE;
+
if (nexcludes == 0 && nincludes == 0)
excludes[nexcludes++] = 1; /* default: ignore RAM disks */
--
1.7.10.4
next prev parent reply other threads:[~2012-07-26 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 12:14 [PATCH] lsblk: support -o +<attr> for adding attribute to output fields Milan Broz
2012-07-26 13:52 ` [PATCH 1/5] Add string_add_to_idarray() - parse and add to id list Milan Broz
2012-07-26 13:52 ` Milan Broz [this message]
2012-07-26 14:47 ` [PATCH 2/5] lsblk: support -o +<attr> for adding attribute to output fields Karel Zak
2012-07-26 13:52 ` [PATCH 3/5] partx: " Milan Broz
2012-07-26 14:47 ` Karel Zak
2012-07-26 13:52 ` [PATCH 4/5] findmnt: " Milan Broz
2012-07-26 14:47 ` Karel Zak
2012-07-26 13:52 ` [PATCH 5/5] wdctl: " Milan Broz
2012-07-26 14:48 ` Karel Zak
2012-07-26 14:46 ` [PATCH 1/5] Add string_add_to_idarray() - parse and add to id list Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343310728-16624-2-git-send-email-mbroz@redhat.com \
--to=mbroz@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).