From: Milan Broz <mbroz@redhat.com>
To: util-linux@vger.kernel.org
Cc: Milan Broz <mbroz@redhat.com>
Subject: [PATCH 3/5] partx: support -o +<attr> for adding attribute to output fields.
Date: Thu, 26 Jul 2012 15:52:06 +0200 [thread overview]
Message-ID: <1343310728-16624-3-git-send-email-mbroz@redhat.com> (raw)
In-Reply-To: <1343310728-16624-1-git-send-email-mbroz@redhat.com>
Signed-off-by: Milan Broz <mbroz@redhat.com>
---
disk-utils/partx.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/disk-utils/partx.c b/disk-utils/partx.c
index 69c559d..8af33ab 100644
--- a/disk-utils/partx.c
+++ b/disk-utils/partx.c
@@ -643,6 +643,7 @@ int main(int argc, char **argv)
char *type = NULL;
char *device = NULL; /* pointer to argv[], ie: /dev/sda1 */
char *wholedisk = NULL; /* allocated, ie: /dev/sda */
+ char *outarg = NULL;
dev_t disk_devno = 0, part_devno = 0;
static const struct option long_opts[] = {
@@ -691,11 +692,7 @@ int main(int argc, char **argv)
errx(EXIT_FAILURE, _("failed to parse --nr <M-N> range"));
break;
case 'o':
- ncolumns = string_to_idarray(optarg,
- columns, ARRAY_SIZE(columns),
- column_name_to_id);
- if (ncolumns < 0)
- return EXIT_FAILURE;
+ outarg = optarg;
exclusive_option(&what, ACT_SHOW, ACT_ERROR);
break;
case 'P':
@@ -740,6 +737,11 @@ int main(int argc, char **argv)
columns[ncolumns++] = COL_UUID;
}
+ if (what == ACT_SHOW && outarg &&
+ string_add_to_idarray(outarg, columns, ARRAY_SIZE(columns),
+ &ncolumns, column_name_to_id) < 0)
+ return EXIT_FAILURE;
+
/*
* Note that 'partx /dev/sda1' == 'partx /dev/sda1 /dev/sda'
* so assume that the device and/or disk are always the last
--
1.7.10.4
next prev parent reply other threads:[~2012-07-26 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 12:14 [PATCH] lsblk: support -o +<attr> for adding attribute to output fields Milan Broz
2012-07-26 13:52 ` [PATCH 1/5] Add string_add_to_idarray() - parse and add to id list Milan Broz
2012-07-26 13:52 ` [PATCH 2/5] lsblk: support -o +<attr> for adding attribute to output fields Milan Broz
2012-07-26 14:47 ` Karel Zak
2012-07-26 13:52 ` Milan Broz [this message]
2012-07-26 14:47 ` [PATCH 3/5] partx: " Karel Zak
2012-07-26 13:52 ` [PATCH 4/5] findmnt: " Milan Broz
2012-07-26 14:47 ` Karel Zak
2012-07-26 13:52 ` [PATCH 5/5] wdctl: " Milan Broz
2012-07-26 14:48 ` Karel Zak
2012-07-26 14:46 ` [PATCH 1/5] Add string_add_to_idarray() - parse and add to id list Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343310728-16624-3-git-send-email-mbroz@redhat.com \
--to=mbroz@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).