From: Milan Broz <mbroz@redhat.com>
To: util-linux@vger.kernel.org
Cc: Milan Broz <mbroz@redhat.com>
Subject: [PATCH 2/3] lsblk: add SCSI H:C:T:L attribute
Date: Fri, 19 Oct 2012 14:10:40 +0200 [thread overview]
Message-ID: <1350648641-19388-2-git-send-email-mbroz@redhat.com> (raw)
In-Reply-To: <1350648641-19388-1-git-send-email-mbroz@redhat.com>
For block devices it is sometimes useful to print SCSI device ID"
Host:Channel:Target:LUN.
Patch adds column name HCTL which can be used in lsblk.
Signed-off-by: Milan Broz <mbroz@redhat.com>
---
misc-utils/lsblk.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/misc-utils/lsblk.c b/misc-utils/lsblk.c
index 1118e7e..7101eed 100644
--- a/misc-utils/lsblk.c
+++ b/misc-utils/lsblk.c
@@ -98,6 +98,7 @@ enum {
COL_WWN,
COL_RAND,
COL_PKNAME,
+ COL_HCTL,
};
/* column names */
@@ -146,6 +147,7 @@ static struct colinfo infos[] = {
[COL_DMAX] = { "DISC-MAX", 6, TT_FL_RIGHT, N_("discard max bytes") },
[COL_DZERO] = { "DISC-ZERO", 1, TT_FL_RIGHT, N_("discard zeroes data") },
[COL_WWN] = { "WWN", 18, 0, N_("unique storage identifier") },
+ [COL_HCTL] = { "HCTL", 10, 0, N_("Host:Channel:Target:Lun for SCSI") },
};
struct lsblk {
@@ -573,6 +575,27 @@ static char *get_type(struct blkdev_cxt *cxt)
return res;
}
+/* H:C:T:L - Host:Channel:Target:LUN */
+static int get_hctl(struct blkdev_cxt *cxt, int *h, int *c, int *t, int *l)
+{
+ char buf[PATH_MAX], *hctl;
+ ssize_t len;
+
+ len = sysfs_readlink(&cxt->sysfs, "device", buf, sizeof(buf));
+ if (len < 0)
+ return 0;
+
+ buf[len] = '\0';
+ hctl = strrchr(buf, '/') + 1;
+ if (!hctl)
+ return 0;
+
+ if (sscanf(hctl, "%d:%d:%d:%d", h, c, t, l) != 4)
+ return 0;
+
+ return 1;
+}
+
#define is_parsable(_l) (((_l)->tt->flags & TT_FL_RAW) || \
((_l)->tt->flags & TT_FL_EXPORT))
@@ -771,6 +794,15 @@ static void set_tt_data(struct blkdev_cxt *cxt, int col, int id, struct tt_line
if (p)
tt_line_set_data(ln, col, p);
break;
+ case COL_HCTL:
+ {
+ int h, c, t, l;
+ if (get_hctl(cxt, &h, &c, &t, &l)) {
+ snprintf(buf, sizeof(buf), "%d:%d:%d:%d", h, c, t, l);
+ tt_line_set_data(ln, col, xstrdup(buf));
+ }
+ break;
+ }
case COL_DALIGN:
p = sysfs_strdup(&cxt->sysfs, "discard_alignment");
if (cxt->discard && p)
--
1.7.10.4
next prev parent reply other threads:[~2012-10-19 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 12:10 [PATCH 1/3] lsblk: add parent kernel name column Milan Broz
2012-10-19 12:10 ` Milan Broz [this message]
2012-10-19 12:10 ` [PATCH 3/3] lsblk: add SCSI transport type attribute Milan Broz
2012-10-23 12:10 ` [PATCH 1/3] lsblk: add parent kernel name column Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350648641-19388-2-git-send-email-mbroz@redhat.com \
--to=mbroz@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).