From: Venkatraman S <venkat@linaro.org>
To: <kzak@redhat.com>
Cc: <util-linux@vger.kernel.org>, <arnd.bergmann@linaro.org>,
Venkatraman S <venkat@linaro.org>
Subject: [PATCH 4/4] mkswap: Probe and embed useful block device info into swapheader
Date: Mon, 22 Oct 2012 22:27:27 +0530 [thread overview]
Message-ID: <1350925048-31084-5-git-send-email-venkat@linaro.org> (raw)
In-Reply-To: <1350925048-31084-1-git-send-email-venkat@linaro.org>
As first step, embed preferred_erase_size into swap header, by probing
the topology.
Not-yet-Signed-off-by: Venkatraman S <venkat@linaro.org>
---
disk-utils/mkswap.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/disk-utils/mkswap.c b/disk-utils/mkswap.c
index f090121..aa61488 100644
--- a/disk-utils/mkswap.c
+++ b/disk-utils/mkswap.c
@@ -59,6 +59,7 @@
#include "c.h"
#include "closestream.h"
#include "ismounted.h"
+#include "bitops.h"
#ifdef HAVE_LIBUUID
# include <uuid.h>
@@ -148,6 +149,7 @@ is_sparc64(void)
*
*/
static unsigned int user_pagesize;
+static unsigned int user_ebsize;
static unsigned int pagesize;
static unsigned long *signature_page = NULL;
@@ -360,6 +362,39 @@ new_prober(int fd)
errx(EXIT_FAILURE, _("unable to assign device to libblkid probe"));
return pr;
}
+
+static void
+add_blkdev_info(struct swap_header_v1_2 *hdr, int fd)
+{
+ char *type = NULL;
+ unsigned long eb_size = 0;
+ blkid_probe pr = new_prober(fd);
+
+ if (user_ebsize) {
+ hdr->swp_headerinfo.blkdevinfo.erase_blk_size = user_ebsize;
+ return;
+ }
+
+ blkid_probe_enable_superblocks(pr, 1);
+ blkid_probe_enable_partitions(pr, 1);
+ blkid_probe_set_superblocks_flags(pr, BLKID_SUBLKS_MAGIC);
+ blkid_probe_enable_topology(pr, 1);
+
+ while (blkid_do_probe(pr) == 0) {
+ if (blkid_probe_lookup_value(pr, "ERASE_BLOCK_SIZE",
+ (const char **) &type, NULL) == 0 && type) {
+ eb_size = strtou32_or_err(type, _("Invalid erase blk size"));
+ hdr->swp_headerinfo.blkdevinfo.erase_blk_size = eb_size;
+ break;
+ }
+ }
+
+}
+
+#else
+static inline void add_blkdev_info(struct swap_header_v1_2 *hdr, int fd)
+{}
+
#endif
static void prepare_header(struct swap_header_v1_2 *hdr,
@@ -625,6 +660,8 @@ main(int argc, char **argv) {
prepare_header(hdr, uuid, opt_label);
+ add_blkdev_info(hdr, DEV);
+
offset = 1024;
if (lseek(DEV, offset, SEEK_SET) != offset)
errx(EXIT_FAILURE, _("unable to rewind swap-device"));
--
1.7.11.1.25.g0e18bef
next prev parent reply other threads:[~2012-10-22 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 16:57 [RFC PATCH 0/4] Adding useful information into swap partition header Venkatraman S
2012-10-22 16:57 ` [RFC PATCH 1/4] libblkid/topology: add preferred_erase_size to topology probe Venkatraman S
2012-10-22 16:57 ` [RFC PATCH 2/4] mkswap: refactor header preparation Venkatraman S
2012-10-22 16:57 ` [RFC PATCH 3/4] mkswap: Add additional fields in swapheader Venkatraman S
2012-10-22 16:57 ` Venkatraman S [this message]
2012-10-22 17:04 ` [RFC PATCH 0/4] Adding useful information into swap partition header Venkatraman S
2012-10-23 12:16 ` Karel Zak
2012-10-23 13:37 ` Venkatraman S
2012-11-08 9:44 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350925048-31084-5-git-send-email-venkat@linaro.org \
--to=venkat@linaro.org \
--cc=arnd.bergmann@linaro.org \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).