util-linux.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] agetty: fix autodetection for TERM
@ 2012-10-29 22:33 Michal Schmidt
  2012-11-02 11:40 ` Karel Zak
  0 siblings, 1 reply; 3+ messages in thread
From: Michal Schmidt @ 2012-10-29 22:33 UTC (permalink / raw)
  To: util-linux

open_tty() autodetects whether to set TERM to "linux" or "vt102", but it
can apply the result only if op->term is still NULL.
---
 term-utils/agetty.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/term-utils/agetty.c b/term-utils/agetty.c
index e53a701..2480f7d 100644
--- a/term-utils/agetty.c
+++ b/term-utils/agetty.c
@@ -283,7 +283,6 @@ int main(int argc, char **argv)
 		.flags  =  F_ISSUE,		/* show /etc/issue (SYSV_STYLE) */
 		.login  =  _PATH_LOGIN,		/* default login program */
 		.tty    = "tty1",		/* default tty line */
-		.term   =  DEFAULT_VCTERM,	/* terminal type */
 		.issue  =  ISSUE		/* default issue file */
 	};
 	char *login_argv[LOGIN_ARGV_MAX + 1];
-- 
1.7.11.7


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] agetty: fix autodetection for TERM
  2012-10-29 22:33 [PATCH] agetty: fix autodetection for TERM Michal Schmidt
@ 2012-11-02 11:40 ` Karel Zak
  2012-11-02 12:56   ` Michal Schmidt
  0 siblings, 1 reply; 3+ messages in thread
From: Karel Zak @ 2012-11-02 11:40 UTC (permalink / raw)
  To: Michal Schmidt; +Cc: util-linux

On Mon, Oct 29, 2012 at 11:33:01PM +0100, Michal Schmidt wrote:
> open_tty() autodetects whether to set TERM to "linux" or "vt102", but it
> can apply the result only if op->term is still NULL.

 Oh, nice. Do you have any reference to bugzilla?

> ---
>  term-utils/agetty.c | 1 -
>  1 file changed, 1 deletion(-)

 Applied, thanks!

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] agetty: fix autodetection for TERM
  2012-11-02 11:40 ` Karel Zak
@ 2012-11-02 12:56   ` Michal Schmidt
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Schmidt @ 2012-11-02 12:56 UTC (permalink / raw)
  To: Karel Zak; +Cc: util-linux

Dne 2.11.2012 12:40, Karel Zak napsal(a):
> On Mon, Oct 29, 2012 at 11:33:01PM +0100, Michal Schmidt wrote:
>> open_tty() autodetects whether to set TERM to "linux" or "vt102", but it
>> can apply the result only if op->term is still NULL.
>
>   Oh, nice. Do you have any reference to bugzilla?

I discovered it while looking into this systemd bug:
https://bugzilla.redhat.com/show_bug.cgi?id=870622#c1

Michal

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-11-02 12:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-29 22:33 [PATCH] agetty: fix autodetection for TERM Michal Schmidt
2012-11-02 11:40 ` Karel Zak
2012-11-02 12:56   ` Michal Schmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).