public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Cody Maloney <cmaloney@theoreticalchaos.com>
To: util-linux@vger.kernel.org
Cc: mitr@redhat.com, Cody Maloney <cmaloney@theoreticalchaos.com>
Subject: [PATCH v3 0/4] Add support for using libuser to chsh and chfn
Date: Wed,  6 Feb 2013 23:22:17 -0700	[thread overview]
Message-ID: <1360218141-4463-1-git-send-email-cmaloney@theoreticalchaos.com> (raw)

I believe these are finally ready for merging. Freshly rebased.
Patches 3 and 4 could be merged, but I think it's a little 
cleaner to read/review with the changes seperate.

Version 3 of the patches, incorporating all changes suggested to 
this point. Only changes from v2 are fixing the error string and
dropping initgroups in patch 3/4.

Tested:
Building and running both with and without libuser support enabled,
with a valid password, invalid password, and running as root.

Cody Maloney (4):
  chsh-chfn: Add flag for enabling/disabling libuser support.
  chsh-chfn: Move pam auth to its own function, factoring out common
    code
  chsh: Add libuser support
  chfn: Add libuser support

 configure.ac              | 17 ++++++++++
 login-utils/Makemodule.am | 10 ++++++
 login-utils/auth.c        | 47 ++++++++++++++++++++++++++++
 login-utils/auth.h        | 13 ++++++++
 login-utils/chfn.c        | 58 +++++++++++++++-------------------
 login-utils/chsh.c        | 53 ++++++++++++++-----------------
 login-utils/libuser.c     | 80 +++++++++++++++++++++++++++++++++++++++++++++++
 login-utils/libuser.h     | 14 +++++++++
 8 files changed, 229 insertions(+), 63 deletions(-)
 create mode 100644 login-utils/auth.c
 create mode 100644 login-utils/auth.h
 create mode 100644 login-utils/libuser.c
 create mode 100644 login-utils/libuser.h

-- 
1.8.1


             reply	other threads:[~2013-02-07  6:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07  6:22 Cody Maloney [this message]
2013-02-07  6:22 ` [PATCH v3 1/4] chsh-chfn: Add flag for enabling/disabling libuser support Cody Maloney
2013-02-13 12:51   ` Karel Zak
2013-02-07  6:22 ` [PATCH v3 2/4] chsh-chfn: Move pam auth to its own function, factoring out common code Cody Maloney
2013-02-13 12:53   ` Karel Zak
2013-02-13 20:33     ` Cody Maloney
2013-02-07  6:22 ` [PATCH v3 3/4] chsh: Add libuser support Cody Maloney
2013-02-13 12:55   ` Karel Zak
2013-02-07  6:22 ` [PATCH v3 4/4] chfn: " Cody Maloney
2013-02-13 13:15   ` Karel Zak
2013-02-13 20:38     ` Cody Maloney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360218141-4463-1-git-send-email-cmaloney@theoreticalchaos.com \
    --to=cmaloney@theoreticalchaos.com \
    --cc=mitr@redhat.com \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox