public inbox for util-linux@vger.kernel.org
 help / color / mirror / Atom feed
From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: kerolasa@iki.fi
Subject: [PATCH 15/16] cal: mark all functions static
Date: Thu,  2 May 2013 19:51:40 +0100	[thread overview]
Message-ID: <1367520701-14962-16-git-send-email-kerolasa@iki.fi> (raw)
In-Reply-To: <1367520701-14962-1-git-send-email-kerolasa@iki.fi>

Proposed-by: Dave Reisner <dreisner@archlinux.org>
Reference: http://marc.info/?l=util-linux-ng&m=136717012419551&w=2
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---
 misc-utils/cal.c | 61 +++++++++++++++++++++++++++++---------------------------
 1 file changed, 32 insertions(+), 29 deletions(-)

diff --git a/misc-utils/cal.c b/misc-utils/cal.c
index 127a855..78f092d 100644
--- a/misc-utils/cal.c
+++ b/misc-utils/cal.c
@@ -227,18 +227,18 @@ static int days_in_month[2][13] = {
 static int leap_year(int year);
 static int centuries_since_1700(int year, int centuries);
 static int leap_years_since_year_1(int year);
-char * ascii_day(const int, char *, int);
-int center_str(const char* src, char* dest, size_t dest_size, size_t width);
-void center(const char *, size_t, int);
-void day_array(const int, const int, int, int, int, int *);
-int day_in_week(int, int, int);
-int day_in_year(int, int, int);
-void yearly(int, int, const int, const int, const char *, const char **);
-void do_monthly(const int, const int, const char *, const char **, int, int, int, struct fmt_st*);
-void monthly(const int, const int, const char *, const char **, int, int, int);
-void monthly3(const int, const int, const char *, const char **, int, int, int);
+static char * ascii_day(const int, char *, int);
+static int center_str(const char* src, char* dest, size_t dest_size, size_t width);
+static void center(const char *, size_t, int);
+static void day_array(const int, const int, int, int, int, int *);
+static int day_in_week(int, int, int);
+static int day_in_year(int, int, int);
+static void yearly(int, int, const int, const int, const char *, const char **);
+static void do_monthly(const int, const int, const char *, const char **, int, int, int, struct fmt_st*);
+static void monthly(const int, const int, const char *, const char **, int, int, int);
+static void monthly3(const int, const int, const char *, const char **, int, int, int);
 static void __attribute__ ((__noreturn__)) usage(FILE * out);
-void headers_init(const int, const int, char *, const char **);
+static void headers_init(const int, const int, char *, const char **);
 
 int
 main(int argc, char **argv) {
@@ -461,8 +461,8 @@ static int leap_years_since_year_1(int year)
 		centuries_since_1700(year, 4));
 }
 
-void headers_init(const int julian, const int weekstart, char *day_headings,
-		  const char **full_month)
+static void headers_init(const int julian, const int weekstart,
+			 char *day_headings, const char **full_month)
 {
 	int i, wd, spaces = julian ? J_DAY_LEN - 1 : DAY_LEN - 1;
 	char *cur_dh = day_headings;
@@ -485,9 +485,9 @@ void headers_init(const int julian, const int weekstart, char *day_headings,
 		full_month[i] = nl_langinfo(MON_1 + i);
 }
 
-void do_monthly(const int julian, const int weekstart, const char *day_headings,
-		const char **full_month, int day, int month, int year,
-		struct fmt_st *out)
+static void do_monthly(const int julian, const int weekstart,
+		       const char *day_headings, const char **full_month,
+		       int day, int month, int year, struct fmt_st *out)
 {
 	int col, row, days[MAXDAYS];
 	char *p, lineout[FMT_ST_CHARS];
@@ -521,8 +521,9 @@ void do_monthly(const int julian, const int weekstart, const char *day_headings,
 	}
 }
 
-void monthly(const int julian, const int weekstart, const char *day_headings,
-	     const char **full_month, int day, int month, int year)
+static void monthly(const int julian, const int weekstart,
+		    const char *day_headings, const char **full_month, int day,
+		    int month, int year)
 {
 	int i;
 	struct fmt_st out;
@@ -534,8 +535,9 @@ void monthly(const int julian, const int weekstart, const char *day_headings,
 	}
 }
 
-void monthly3(const int julian, const int weekstart, const char *day_headings,
-	      const char **full_month, int day, int month, int year)
+static void monthly3(const int julian, const int weekstart,
+		     const char *day_headings, const char **full_month, int day,
+		     int month, int year)
 {
 	char lineout[FMT_ST_CHARS];
 	int i;
@@ -590,8 +592,8 @@ void monthly3(const int julian, const int weekstart, const char *day_headings,
 	}
 }
 
-void yearly(int day, int year, const int julian, const int weekstart,
-	    const char *day_headings, const char **full_month)
+static void yearly(int day, int year, const int julian, const int weekstart,
+		   const char *day_headings, const char **full_month)
 {
 	int col, *dp, i, month, row, which_cal;
 	int maxrow, sep_len, week_len;
@@ -655,8 +657,8 @@ void yearly(int day, int year, const int julian, const int weekstart,
  *	out end to end.  You would have 42 numbers or spaces.  This routine
  *	builds that array for any month from Jan. 1 through Dec. 9999.
  */
-void day_array(const int julian, const int weekstart, int day, int month,
-	       int year, int *days)
+static void day_array(const int julian, const int weekstart, int day, int month,
+		      int year, int *days)
 {
 	int julday, daynum, dw, dm;
 	int *sep1752;
@@ -687,7 +689,7 @@ void day_array(const int julian, const int weekstart, int day, int month,
  * day_in_year --
  *	return the 1 based day number within the year
  */
-int day_in_year(int day, int month, int year)
+static int day_in_year(int day, int month, int year)
 {
 	int i, leap;
 
@@ -704,7 +706,7 @@ int day_in_year(int day, int month, int year)
  *	3 Sep. 1752 through 13 Sep. 1752.  Returns Thursday for all
  *	missing days.
  */
-int day_in_week(int day, int month, int year)
+static int day_in_week(int day, int month, int year)
 {
 	long temp;
 
@@ -719,7 +721,7 @@ int day_in_week(int day, int month, int year)
 	return(REFORMATION_WEEKDAY);
 }
 
-char *ascii_day(const int julian, char *p, int day)
+static char *ascii_day(const int julian, char *p, int day)
 {
 	int display, val;
 	int highlight = 0;
@@ -772,13 +774,14 @@ char *ascii_day(const int julian, char *p, int day)
  * In addition if the string is too large for the width it's truncated.
  * The number of trailing spaces may be 1 less than the number of leading spaces.
  */
-int center_str(const char *src, char *dest, size_t dest_size, size_t width)
+static int center_str(const char *src, char *dest, size_t dest_size,
+		      size_t width)
 {
 	return mbsalign(src, dest, dest_size, &width,
 			MBS_ALIGN_CENTER, MBA_UNIBYTE_FALLBACK);
 }
 
-void center(const char *str, size_t len, int separate)
+static void center(const char *str, size_t len, int separate)
 {
 	char lineout[FMT_ST_CHARS];
 
-- 
1.8.2.2


  parent reply	other threads:[~2013-05-02 18:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 18:51 [PATCH 00/16]: [pull] cal: second review round Sami Kerola
2013-05-02 18:51 ` [PATCH 01/16] cal: fix preprocessor directive indendation Sami Kerola
2013-05-02 18:51 ` [PATCH 02/16] cal: convert function like definitions to functions Sami Kerola
2013-05-02 18:51 ` [PATCH 03/16] cal: clean up use of constants Sami Kerola
2013-05-02 18:51 ` [PATCH 04/16] tests: add calendar reformation check Sami Kerola
2013-05-02 18:51 ` [PATCH 05/16] cal: simplify calendar reformat calculations Sami Kerola
2013-05-02 18:51 ` [PATCH 06/16] cal: remove unnecessary initializations Sami Kerola
2013-05-02 18:51 ` [PATCH 07/16] cal: de-duplicate julian specific functions Sami Kerola
2013-05-02 18:51 ` [PATCH 08/16] lib: copy argmatch from gnulib Sami Kerola
2013-05-06 17:16   ` Karel Zak
2013-05-07 21:14     ` Sami Kerola
2013-05-02 18:51 ` [PATCH 09/16] cal: add --highligth option which uses argmatch Sami Kerola
2013-05-06  0:11   ` Pádraig Brady
2013-05-06 10:44     ` Sami Kerola
2013-05-06 17:19   ` Karel Zak
2013-05-02 18:51 ` [PATCH 10/16] cal: add --highlight to usage() Sami Kerola
2013-05-02 18:51 ` [PATCH 11/16] docs: cal: add --highlight option description Sami Kerola
2013-05-02 18:51 ` [PATCH 12/16] tests: add cal day highlight corner cases Sami Kerola
2013-05-02 18:51 ` [PATCH 13/16] cal: stop trimming whitespaces Sami Kerola
2013-05-06  0:12   ` Pádraig Brady
2013-05-14 10:45   ` Karel Zak
2013-05-21 20:34     ` Sami Kerola
2013-05-02 18:51 ` [PATCH 14/16] cal: move global variables to local scope Sami Kerola
2013-05-14 10:49   ` Karel Zak
2013-05-02 18:51 ` Sami Kerola [this message]
2013-05-02 18:51 ` [PATCH 16/16] cal: simplify day_in_week() Sami Kerola
2013-05-03 20:19   ` Sami Kerola

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367520701-14962-16-git-send-email-kerolasa@iki.fi \
    --to=kerolasa@iki.fi \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox