Re: [PATCH 04/19] sfdisk: use libc error printing function, and symbolic exit values

Karel Zak
2013-06-07T10:20:37Z

On Sun, Jun 02, 2013 at 06:51:10PM +0100, Sami Kerola wrote:
> if ((out = lseek(fd, in, SEEK_SET)) != in) {
> perror("lseek");
> - error(_("seek error on %s - cannot seek to %lu\n"), dev, s);
> + warnx(_("seek error on %s - cannot seek to %lu"), dev, s);
> return 0;

I don't think that perror() + warnx() is elegant solution, just use
warn() only.

warn(_("seek failed %s" - cannot seek to %lu"), dev, s);

Karel

--
Karel Zak <kzak@redhat.com>