Re: [PATCH 00/34] pull: make printing quicker, and clang analysis

Karel Zak
2013-07-09T12:58:27Z

On Sun, Jul 07, 2013 at 08:54:15PM +0100, Sami Kerola wrote:
> sfdisk: make unhiding as complete as possible
> docs: add missing options to sfdisk manual

Applied.

> include: copy unlocked-io.h from gnulib
> hexdump: use unlocked io, and avoid use of printf()
> text-utils: use unlocked io
> misc-utils: use unlocked io
> scriptreplay: use unlocked io
> dmesg: use unlocked io, and avoid use of printf()
> utmpdump: use unlocked io, and avoid use of printf()

Postponed.

> dmesg: inform user --show-delta and iso8601 time format does not mix
> lib/loopdev: assigned value is never read [clang-analyzer]
> lib/mbsalign: initializations values are never read [clang-analyzer]
> libmount: fix memory leak [clang-analyzer]

Fixed and applied.

> ipcs: assigned values are never read [clang-analyzer]
> lscpu: fix memory leak [clang-analyzer]
> more: assigned value is never read [clang-analyzer]
> utmpdump: assigned values are never read [clang-analyzer]
> mkfs.cramfs: argument to free() is a constant address [clang-analyzer]
> eject: assigned value is never read [clang-analyzer]
> chfn: assigned value is never read [clang-analyzer]

Applied.

> mesg: assigned value is never read [clang-analyzer]
> rev: assigned value is never read [clang-analyzer]
> column: assigned value is never read [clang-analyzer]
> hwclock: assigned value is never read [clang-analyzer]
> dmesg: assigned value is never read [clang-analyzer]
> login: assigned value is never read [clang-analyzer]
> fdisk: assigned value is never read [clang-analyzer]

Ignored as keep argv and argc consistent seems better.

> sulogin: fix memory leak [clang-analyzer]
> agetty: fix memory leak [clang-analyzer]
> dmesg: add missing initializer [clang-analyzer]
^^^^^
uuidd:

Fixed & applied.

> ul: use correct types
> ul: use string printing function
> column: dereference of null pointer [clang-analyzer]
> more: use variable lenght printf field width to print blanks

Applied (with some changes).

Karel

--
Karel Zak <kzak@redhat.com>