Re: [PATCH 21/34] mesg: assigned value is never read [clang-analyzer]

Karel Zak
2013-07-08T08:23:56Z

On Sun, Jul 07, 2013 at 08:54:36PM +0100, Sami Kerola wrote:
> Signed-off-by: Sami Kerola <kerolasa@iki.fi>
> ---
> term-utils/mesg.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/term-utils/mesg.c b/term-utils/mesg.c
> index 430236f..638a8c7 100644
> --- a/term-utils/mesg.c
> +++ b/term-utils/mesg.c
> @@ -115,7 +115,6 @@ int main(int argc, char *argv[])
> usage(stderr);
> }
>
> - argc -= optind;
> argv += optind;

This is technically correct change, but I don't think it makes code
more robust. The argv[] and argc are twins and it's bad coding style
manner to divide the relation.

Karel

--
Karel Zak <kzak@redhat.com>