From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: kerolasa@iki.fi
Subject: [PATCH 00/17] pull: term-utils changes with emphasis on last(1)
Date: Tue, 27 Aug 2013 19:06:03 +0100 [thread overview]
Message-ID: <1377626779-26030-1-git-send-email-kerolasa@iki.fi> (raw)
Notice that the first patch is skipped intentionally. I sent it already
yesterday, but it is in my git tree if someone prefers inspecting the
work that way.
The patches 02 to 08 are fairly trivial changes, and commit messages
should be enough.
The 09 is perhaps more interesting. I were unable to send with write(1)
a message from one of my own terminals to other when mesg(1) had enabled.
Because I felt that is unexpeceted the 09 will change how write(1) will
determine messaging permission. As with any permissions change it would
be great to get this change properly scrutinised.
>From patch 10 onwards the changes are mostly outcome of earlier request
in the maillist.
http://www.spinics.net/lists/util-linux-ng/msg08227.html
To make time format parsing user friendly I decided to plunder code from
systemd. It is a pity there does not seem to be libtime for all sorts of
time related format parsing, conversions, etc high level needs to avoid
each project doing these on their own.
The last command got couple new options, --since and --time-format, which
hopefully make the utility more useful. The patch 15 aims to make
contributors happier by removing bunch of global variables, and simplify
function argument passing.
Looking these changes I realized there is still at least one last(1) thing
missing. The last(1) test coverage is zero. If I don't need to rewrite
all/most of these patches I could concentrate the tests next.
Meanwhile all sort of comments, proposals, and corrections are welcome.
The following changes since commit ef2c9e3f5e51cf13ec9cf6738d4f1d695ee32a6f:
tests: minor changes to make tests more portable (2013-08-26 13:48:40 +0200)
are available in the git repository at:
git://github.com/kerolasa/lelux-utiliteetit.git 2013wk34
for you to fetch changes up to 69d9bdd65371edf37bb20308582f05fe2c095195:
docs: add --time-format to last(1) manual page (2013-08-27 18:15:00 +0100)
----------------------------------------------------------------
Sami Kerola (17):
build-sys: pylibmount will not work when python3 is present
wall: send message also to sessions opened by user 'sleeper'
last: fix typo
wall: sync usage() with howto-usage-function.txt
mesg: sync usage() with howto-usage-function.txt
wall: line wrap at column 79 also when line has tab chars
docs: add --present to last(1) manual page
docs: add note to wall(1) about sessions which will not get message
write: change determination can user write to a terminal
lib/time-util: copy time parsing functions from systemd
last: parse easy to use time formats
last: add --since time spec option
docs: add --since and time option formats to last(1) manual
last: fix --present option logic error
last: use configuration struct
last: add --time-format with iso-8601 format
docs: add --time-format to last(1) manual page
configure.ac | 6 +
include/Makemodule.am | 1 +
include/time-util.h | 55 +++++++
lib/Makemodule.am | 1 +
lib/time-util.c | 388 ++++++++++++++++++++++++++++++++++++++++++++++
login-utils/Makemodule.am | 1 +
login-utils/last.1 | 63 +++++++-
login-utils/last.c | 359 ++++++++++++++++++++++++++++--------------
term-utils/mesg.c | 15 +-
term-utils/wall.1 | 6 +
term-utils/wall.c | 28 ++--
term-utils/write.c | 9 +-
12 files changed, 784 insertions(+), 148 deletions(-)
create mode 100644 include/time-util.h
create mode 100644 lib/time-util.c
next reply other threads:[~2013-08-27 18:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 18:06 Sami Kerola [this message]
2013-08-27 18:06 ` [PATCH 02/17] wall: send message also to sessions opened by user 'sleeper' Sami Kerola
2013-08-27 18:06 ` [PATCH 03/17] last: fix typo Sami Kerola
2013-08-27 18:06 ` [PATCH 04/17] wall: sync usage() with howto-usage-function.txt Sami Kerola
2013-08-27 18:06 ` [PATCH 05/17] mesg: " Sami Kerola
2013-08-27 18:06 ` [PATCH 06/17] wall: line wrap at column 79 also when line has tab chars Sami Kerola
2013-08-27 18:06 ` [PATCH 07/17] docs: add --present to last(1) manual page Sami Kerola
2013-08-27 18:06 ` [PATCH 08/17] docs: add note to wall(1) about sessions which will not get message Sami Kerola
2013-08-27 18:06 ` [PATCH 09/17] write: change determination can user write to a terminal Sami Kerola
2013-08-27 18:06 ` [PATCH 10/17] lib/time-util: copy time parsing functions from systemd Sami Kerola
2013-08-29 10:11 ` Karel Zak
2013-08-29 18:02 ` Sami Kerola
2013-08-27 18:06 ` [PATCH 11/17] last: parse easy to use time formats Sami Kerola
2013-08-29 10:09 ` Karel Zak
2013-08-29 18:01 ` Sami Kerola
2013-08-27 18:06 ` [PATCH 12/17] last: add --since time spec option Sami Kerola
2013-08-27 18:06 ` [PATCH 13/17] docs: add --since and time option formats to last(1) manual Sami Kerola
2013-08-27 18:06 ` [PATCH 14/17] last: fix --present option logic error Sami Kerola
2013-08-27 18:06 ` [PATCH 15/17] last: use configuration struct Sami Kerola
2013-08-29 10:15 ` Karel Zak
2013-08-29 18:06 ` Sami Kerola
2013-09-02 9:10 ` Karel Zak
2013-08-27 18:06 ` [PATCH 16/17] last: add --time-format with iso-8601 format Sami Kerola
2013-08-27 18:06 ` [PATCH 17/17] docs: add --time-format to last(1) manual page Sami Kerola
2013-09-02 9:59 ` [PATCH 00/17] pull: term-utils changes with emphasis on last(1) Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1377626779-26030-1-git-send-email-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox