From: Sami Kerola <kerolasa@iki.fi>
To: util-linux@vger.kernel.org
Cc: kerolasa@iki.fi
Subject: [PATCH 00/13] pull: cal: code revisit part I try II
Date: Sun, 10 Nov 2013 18:23:27 +0000 [thread overview]
Message-ID: <1384107820-498-1-git-send-email-kerolasa@iki.fi> (raw)
Hi Karel and others,
You might remember attempt to refactor cal(1) from couple weeks.
http://www.spinics.net/lists/util-linux-ng/index.html#08443
This patch set / pull request is fairly similar to previous. Difference
are with variable and function naming, and output generator and printout
routines. Essentially the changes proposed by Karel should at least
partly done, and I am happy that the code quality clearly increased in
between tries.
Notice that this is 'revist part I'. These changes will allow new
features, such as variable number horizontal calendar outputs, and
printout of user defined calendar months that cross year boundaries. I
do not think I will have time to work with these feature before end of
the month. I am perfectly ok if if someone does the next stuff, but if
not I'll have a look of that about in December.
The following changes since commit 5dc242cc97b2323c2540a7f13be72c678f0b6b58:
tests: update blkid swap tests (2013-11-08 14:22:35 +0100)
are available in the git repository at:
git://github.com/kerolasa/lelux-utiliteetit.git cal-ng
for you to fetch changes up to 543a04eb8db8ddf74da1c5ec044d5df83f1f2f17:
cal: use month contents structure for --year printing (2013-11-10 18:20:27 +0000)
----------------------------------------------------------------
Sami Kerola (13):
cal: use control structure for run time configuration
cal: rename ascii_wnum() to ascii_weeknum()
cal: add input variable names to function prototypes
cal: make day_in_week() use same variable names as other functions
cal: simplify ascii_weeknum() function
cal: determine output width at beginning of run and reuse result
tests: cal: take account week numbers when determing month lenght
cal: make user request to be part of read-only control struct
tests: cal: do not let --week=<num> to adjust requested month
cal: determine how many header lines are needed at initialization
cal: add month contents structure
cal: use month contents structure for --three printing
cal: use month contents structure for --year printing
misc-utils/cal.c | 781 ++++++++++++++++++++------------------------
tests/expected/cal/bigyearw | 12 +-
tests/expected/cal/weekarg | 84 ++---
3 files changed, 405 insertions(+), 472 deletions(-)
next reply other threads:[~2013-11-10 18:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-10 18:23 Sami Kerola [this message]
2013-11-10 18:23 ` [PATCH 01/13] cal: use control structure for run time configuration Sami Kerola
2013-11-10 18:23 ` [PATCH 02/13] cal: rename ascii_wnum() to ascii_weeknum() Sami Kerola
2013-11-10 18:23 ` [PATCH 03/13] cal: add input variable names to function prototypes Sami Kerola
2013-11-10 18:23 ` [PATCH 04/13] cal: make day_in_week() use same variable names as other functions Sami Kerola
2013-11-10 18:23 ` [PATCH 05/13] cal: simplify ascii_weeknum() function Sami Kerola
2013-11-10 18:23 ` [PATCH 06/13] cal: determine output width at beginning of run and reuse result Sami Kerola
2013-11-10 18:23 ` [PATCH 07/13] tests: cal: take account week numbers when determing month lenght Sami Kerola
2013-11-10 18:23 ` [PATCH 08/13] cal: make user request to be part of read-only control struct Sami Kerola
2013-11-10 18:23 ` [PATCH 09/13] tests: cal: do not let --week=<num> to adjust requested month Sami Kerola
2013-11-10 18:23 ` [PATCH 10/13] cal: determine how many header lines are needed at initialization Sami Kerola
2013-11-10 18:23 ` [PATCH 11/13] cal: add month contents structure Sami Kerola
2013-11-10 18:23 ` [PATCH 12/13] cal: use month contents structure for --three printing Sami Kerola
2013-12-06 10:07 ` Karel Zak
2013-11-10 18:23 ` [PATCH 13/13] cal: use month contents structure for --year printing Sami Kerola
2013-12-06 10:02 ` [PATCH 00/13] pull: cal: code revisit part I try II Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384107820-498-1-git-send-email-kerolasa@iki.fi \
--to=kerolasa@iki.fi \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox