Re: [PATCH 05/10] kill: make usage() not to return

Sami Kerola
2014-03-19T19:02:24Z

On 19 March 2014 12:37, Benno Schulenberg <bensberg@justemail.net> wrote:
> On Sun, Mar 9, 2014, at 21:30, Sami Kerola wrote:
>> And change the function argument to be output stream. Earlier the --help
>> made kill to exit with none zero value, that now is corrected.
>
> Textual amendments:
>
> s/be/be an/
> s/made/option made/
> s/to exit/exit/
> s/none zero/non-zero/
> s/now is/is now/
>
> Or in summary:
>
> And change the function argument to be an output stream. Earlier the
> --help option made kill exit with a non-zero value; that is now corrected.

Thank you Benno, and Q.E.D. my English is rubbish.

Karel, that correction and the earlier fstrim exit code definition
reshuffle can be found from my git. Details for easy merge are below.

--- snip
The following changes since commit 422f93bfbb5df358fad3fedfe9eb0247cbf3cb14:

include/closestream: don't wipe errno on EPIPE (2014-03-13 12:41:03 +0100)

are available in the git repository at:

git://github.com/kerolasa/lelux-utiliteetit.git 2014wk09

for you to fetch changes up to 6a02f1dd9639b8b13c318a061951bc7b7a8b8f6e:

kill: move sigqueue inputs to control struct (2014-03-19 18:57:21 +0000)

----------------------------------------------------------------
Sami Kerola (16):
build-sys: unify function and variable attribute spacing
mcookie: use lib/randutils
mcookie: allow --file option be defined multiple times
mcookie: use same variable type consistently
mcookie: use control structure, and fix usage()
mcookie: add --max-size option
findfs: use symbolic exit values, and tell about them in manual
kill: fix coding style
kill: flip all comparions to be in smaller - greater order
kill: move magic numbers in beginning of the file
kill: make usage() not to return
kill: deprecat invocation as 'pid' command name
kill: use control structure to pass user input to functions
kill: tell what is wrong rather than output usage()
kill: add parse_arguments() function
kill: move sigqueue inputs to control struct

--
Sami Kerola