Re: [PATCH 06/10] kill: leeway deprecation of --pid invocation as command name

Sami Kerola
2014-03-11T12:13:21Z

On 11 March 2014 02:21, Bernhard Voelker <mail@bernhard-voelker.de> wrote:
> On 03/09/2014 09:30 PM, Sami Kerola wrote:
>> diff --git a/misc-utils/kill.c b/misc-utils/kill.c
>> index 2fecda3..11c8cd2 100644
>> --- a/misc-utils/kill.c
>> +++ b/misc-utils/kill.c
>> @@ -170,6 +170,8 @@ int main(int argc, char **argv)
>>
>> numsig = SIGTERM;
>> do_pid = (!strcmp(program_invocation_short_name, "pid")); /* Yecch */
>> + if (do_pid)
>> + warnx(_("use of 'kill --pid' option as command name will be deprecated in future"));
>
> You deprecate now:
> s/will .* future/is deprecated/
>
>
> Another minor note:
> Shouldn't there be something like a
>
> + /* FIXME: remove in March 2016. */
>
> together with deprecations like that?
> It would be easier to find and fix then.

Hi Bernhard,

Thank you for comment. Now when I think about deprecation it does
happen immediately, while removal follows later. Both the time change,
and FIXME are available in github, with corrections to two later
commits are available in the git repository at:

git://github.com/kerolasa/lelux-utiliteetit.git 2014wk09

for you to fetch changes up to 2b0dda54bda3ecd24ca1de4cfd7eb662438204cc.

--
Sami Kerola