From: Hannes Reinecke <hare@suse.de>
To: Karel Zak <kzak@redhat.com>
Cc: Werner Fink <werner@suse.de>, Stanislav Brabec <sbrabec@suse.com>,
<util-linux@vger.kernel.org>, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv3 0/2] Abort blkid probing errors
Date: Thu, 20 Mar 2014 11:03:48 +0100 [thread overview]
Message-ID: <1395309830-58744-1-git-send-email-hare@suse.de> (raw)
Whenever blkid incurs an error during probing it should abort all probes,
as any result will be bogus anyway. Plus blkid will taking
ages to complete on faulty devices, stalling the uevent queue
and resulting in udev killing the process eventually.
With this patch the number of I/O errors during
blkid run is cut from 156 to just 2.
Changes to v1:
- Fixup issues found when running 'make check'
- Only fail for I/O errors
Changes to v2:
- Return error code instead of -1
- Correctly terminate probing loop
- Return correct error code when probing partitions
Hannes Reinecke (2):
blkid: stop scanning on I/O error
blkid: convert superblocks to new calling convention
libblkid/src/blkidP.h | 3 ++
libblkid/src/partitions/aix.c | 2 +-
libblkid/src/partitions/bsd.c | 28 ++++++++++-------
libblkid/src/partitions/dos.c | 40 ++++++++++++++----------
libblkid/src/partitions/gpt.c | 29 ++++++++++++------
libblkid/src/partitions/mac.c | 25 ++++++++++-----
libblkid/src/partitions/minix.c | 17 +++++-----
libblkid/src/partitions/partitions.c | 44 ++++++++++++++------------
libblkid/src/partitions/sgi.c | 15 +++++----
libblkid/src/partitions/solaris_x86.c | 15 +++++----
libblkid/src/partitions/sun.c | 17 +++++-----
libblkid/src/partitions/ultrix.c | 15 +++++----
libblkid/src/partitions/unixware.c | 15 +++++----
libblkid/src/probe.c | 30 +++++++++++++++---
libblkid/src/superblocks/adaptec_raid.c | 15 ++++-----
libblkid/src/superblocks/bcache.c | 4 +--
libblkid/src/superblocks/befs.c | 26 ++++++++--------
libblkid/src/superblocks/btrfs.c | 2 +-
libblkid/src/superblocks/cramfs.c | 2 +-
libblkid/src/superblocks/ddf_raid.c | 19 +++++++-----
libblkid/src/superblocks/drbd.c | 8 ++---
libblkid/src/superblocks/drbdproxy_datalog.c | 2 +-
libblkid/src/superblocks/exfat.c | 4 ++-
libblkid/src/superblocks/ext.c | 30 +++++++++---------
libblkid/src/superblocks/f2fs.c | 2 +-
libblkid/src/superblocks/gfs.c | 8 ++---
libblkid/src/superblocks/hfs.c | 12 ++++----
libblkid/src/superblocks/highpoint_raid.c | 12 ++++----
libblkid/src/superblocks/hpfs.c | 8 ++---
libblkid/src/superblocks/iso9660.c | 4 +--
libblkid/src/superblocks/isw_raid.c | 13 ++++----
libblkid/src/superblocks/jfs.c | 2 +-
libblkid/src/superblocks/jmicron_raid.c | 13 ++++----
libblkid/src/superblocks/linux_raid.c | 46 ++++++++++++++++------------
libblkid/src/superblocks/lsi_raid.c | 10 +++---
libblkid/src/superblocks/luks.c | 2 +-
libblkid/src/superblocks/lvm.c | 6 ++--
libblkid/src/superblocks/minix.c | 18 ++++++-----
libblkid/src/superblocks/netware.c | 2 +-
libblkid/src/superblocks/nilfs.c | 4 +--
libblkid/src/superblocks/ntfs.c | 6 ++--
libblkid/src/superblocks/nvidia_raid.c | 12 ++++----
libblkid/src/superblocks/ocfs.c | 8 ++---
libblkid/src/superblocks/promise_raid.c | 10 +++---
libblkid/src/superblocks/reiserfs.c | 8 ++---
libblkid/src/superblocks/romfs.c | 2 +-
libblkid/src/superblocks/silicon_raid.c | 10 +++---
libblkid/src/superblocks/squashfs.c | 2 +-
libblkid/src/superblocks/superblocks.c | 38 +++++++++++++++--------
libblkid/src/superblocks/swap.c | 24 +++++++--------
libblkid/src/superblocks/sysv.c | 8 ++---
libblkid/src/superblocks/ubifs.c | 2 +-
libblkid/src/superblocks/udf.c | 16 +++++-----
libblkid/src/superblocks/ufs.c | 4 +--
libblkid/src/superblocks/vfat.c | 16 +++++-----
libblkid/src/superblocks/via_raid.c | 6 ++--
libblkid/src/superblocks/vmfs.c | 4 +--
libblkid/src/superblocks/vxfs.c | 2 +-
libblkid/src/superblocks/xfs.c | 6 ++--
libblkid/src/superblocks/zfs.c | 6 ++--
60 files changed, 435 insertions(+), 324 deletions(-)
--
1.7.12.4
next reply other threads:[~2014-03-20 10:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 10:03 Hannes Reinecke [this message]
2014-03-20 10:03 ` [PATCH 1/2] blkid: stop scanning on I/O error Hannes Reinecke
2014-03-20 10:48 ` Karel Zak
2014-03-20 10:03 ` [PATCH 2/2] blkid: convert superblocks to new calling convention Hannes Reinecke
2014-03-20 18:14 ` [PATCHv3 0/2] Abort blkid probing errors Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395309830-58744-1-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=kzak@redhat.com \
--cc=sbrabec@suse.com \
--cc=util-linux@vger.kernel.org \
--cc=werner@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox