Re: [PATCH 08/12] swapon: swaps with legacy version label are not supported

Karel Zak
2014-04-28T09:47:03Z

On Mon, Apr 28, 2014 at 09:44:01AM +0100, Sami Kerola wrote:
> On 28 April 2014 09:37, Benno Schulenberg <bensberg@justemail.net> wrote:
> >
> > On Sun, Apr 27, 2014, at 22:05, Sami Kerola wrote:
> >> - if (memcmp(buf, "SWAP-SPACE", 10) == 0 ||
> >> - memcmp(buf, "SWAPSPACE2", 10) == 0)
> >> + if (memcmp(buf, SWAP_SIGNATURE, 10) == 0)
> >
> > s/10/SWAP_SIGNATURE_SZ/ ?
>
> Hi Benno,
>
> Yes, that would be better. Karel, can you amend & add Benno as reviewer?

Sure, what about to add macro is_swap_magic() to include/ to hide all the
details? BTW, there is also libblkid/src/superblocks/swap.c :-)

Karel

--
Karel Zak <kzak@redhat.com>