Re: [PATCH 00/12] pull: mostly swap command clarifications

Sami Kerola
2014-04-29T21:05:24Z

On 27 April 2014 21:05, Sami Kerola <kerolasa@iki.fi> wrote:
> are available in the git repository at:
>
> git://github.com/kerolasa/lelux-utiliteetit.git 2014wk16

[snip]

> include/xalloc: ensure arithmetics overflow cannot happen
> dmesg: move get_boot_time() to lib/timeutils
> last: fix is_phantom() detection
> include/c.h: add macro to print definitions as string
> mkswap, swaplabel: move version number to header
> mkswap: remove legacy swap structure
> include/swapheader.h: ensure type sizes
> swapon: swaps with legacy version label are not supported
> swapon, swapheader, mkswap: move swap signature to header
> libsmartcols: remove ununsed assignment
> lib/timeutils: fix memory leak
> lib/pager: use names when referring to standard file descriptors

Good evening,

I got rid of the xalloc change, with intention to send some sort of
xrecalloc() later. The 'swapon: swaps with legacy version label are
not supported' patch now uses SWAP_SIGNATURE_SZ instead of magic
number & Bernhard is added as reviewer. Karel, I am not sure if I got
the libsmartcols check right so please ensure the logic is correct.

Corrected versions of the patches are available from my github remote
branch that is using the same name as previous time I sent these. IMHO
the changes are pretty small, so resubmission is not (yet) necessary.
If there's more feedback that might change.

--
Sami Kerola